kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 21/06/2015 14:13, Marco Hess a écrit :
> Attached a patch with a fix for the 'sloppy' board outline tracing that
> was used in pcbnew/specctra_export.cpp
> 
> I submitted a similar patch earlier but that has not been merged yet.
> That previous patch may also have been a bit more messy and in some
> spots even violated the coding rules.
> 
> So with this patch consider the previous similar patch NULL and void.
> 
> I also revisited this code in light of the recent DXF closed polygon
> fix. The existing code in specctra_export for the outline tracing had a
> few problems when the segment size became quite small and selecting
> between the begin and end of a next segment. In some case the 0.01 limit
> used was also too small.
> 
> The updated algorithm explicitlty chooses the closest end of a new
> segment to be appended. It  also only terminates the path tracing when
> there really are no more segments available within the 0.05 mm limit
> distance. The previous code was testing to close the polygon before it
> checking to see if there were more close segments and hence could
> prematurely exit the path tracing which would leave some segments dangling.
> 
> I hope this can still be considered for the upcoming 'stable' release.
> 
> Cheers,
> 
> Marco

Sorry for the delay.

I committed it. Thanks.


-- 
Jean-Pierre CHARRAS