← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Skip redundant repetition of component name in component chooser

 

I am assuming that it is only removed from the description when it matches the component name?

i.e. If I use a different naming convention where the component name is not necessarily repeated in the description, this patch is a NOOP?

On 26-Jun-15 11:58, Henner Zeller wrote:
On 25 June 2015 at 19:18, Chris Pavlina <pavlina.chris@xxxxxxxxx> wrote:
Any chance of making it configurable? Or at least, of not being offended
if I throw in a patch to do that? ;)
What do you want to make configurable ? Do you _want_ to see the
redundant information ?

On Thu, Jun 25, 2015 at 07:15:36PM -0700, Henner Zeller wrote:
On 25 June 2015 at 19:09, Chris Pavlina <pavlina.chris@xxxxxxxxx> wrote:
Are you positive that a better fix wouldn't be to stop putting redundant
things in component descriptions?
It would be good if that wouldn't happen, yes.
But I can't change all the libraries that exist in the world; changing
only the KiCAD internal libraries would probably be feasible (need to
hack up something) and should probably be done independently.

This change helps to have KiCAD behave best in the real world.

-h

On Thu, Jun 25, 2015 at 06:24:33PM -0700, Henner Zeller wrote:
Hi,
In component descriptions, often the first word in the description is
a repetition of the component name. While this is generally not a
problem when reading this in a description box, if displayed in the
brief description in the tree view, this is redundant information,
taking space of more relevant information (see first attachment
picture).

This patch uses some heuristic to get rid of these and thus generally
improves the experience for these components:

https://github.com/hzeller/kicad/compare/skip-redundant-name-repetition-in-tree.diff

See second picture for an example.

Henner.


_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

--
Chris

_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp
_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

--
Marco Hess
Through IP Pty. Ltd. - AUSTRALIA
www.through-ip.com  | marco.hess@xxxxxxxxxxxxxx
p: +61 407 78 55 66 | f: +61 8 8121 6191



Follow ups

References