← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Skip redundant repetition of component name in component chooser

 

On 25 June 2015 at 19:32, Chris Pavlina <pavlina.chris@xxxxxxxxx> wrote:
> I want the description column to show exactly what's in the component
> description field, as it does now.

Note, the description is not affected in the little description box in
the bottom right. Only in the list view, where space is precious.

> I'm not opposed to different
> behavior, I'd just ideally like an optional way to keep it the way it
> is. I maintain my own libraries, and if there's something wrong with
> them like that, I'd rather see it so I can fix it!

Fair enough.
Maybe this should be different if this dialog is used in the library
editor (where this information could be useful) vs. eeschema (where
redundant information is annoying).

>
> I don't think I'm the only one who'd like to see major interface
> elements like that stay relatively simple and predictable.
>
> It's POLA - it claims to be a description column, so you expect it to
> directly show the description.

Well, it doesn't really claim to be a description column anywhere.

> https://en.wikipedia.org/wiki/Principle_of_least_astonishment

I don't think invoking Pola applies here. It only removes something
that has been written a couple of pixels before. So for a human user
this is not astonishing at all. It is rather annoying if it _not_
happens.

-h

>
>
> On Thu, Jun 25, 2015 at 07:28:31PM -0700, Henner Zeller wrote:
>> On 25 June 2015 at 19:18, Chris Pavlina <pavlina.chris@xxxxxxxxx> wrote:
>> > Any chance of making it configurable? Or at least, of not being offended
>> > if I throw in a patch to do that? ;)
>>
>> What do you want to make configurable ? Do you _want_ to see the
>> redundant information ?
>>
>> >
>> > On Thu, Jun 25, 2015 at 07:15:36PM -0700, Henner Zeller wrote:
>> >> On 25 June 2015 at 19:09, Chris Pavlina <pavlina.chris@xxxxxxxxx> wrote:
>> >> > Are you positive that a better fix wouldn't be to stop putting redundant
>> >> > things in component descriptions?
>> >>
>> >> It would be good if that wouldn't happen, yes.
>> >> But I can't change all the libraries that exist in the world; changing
>> >> only the KiCAD internal libraries would probably be feasible (need to
>> >> hack up something) and should probably be done independently.
>> >>
>> >> This change helps to have KiCAD behave best in the real world.
>> >>
>> >> -h
>> >>
>> >> >
>> >> > On Thu, Jun 25, 2015 at 06:24:33PM -0700, Henner Zeller wrote:
>> >> >> Hi,
>> >> >> In component descriptions, often the first word in the description is
>> >> >> a repetition of the component name. While this is generally not a
>> >> >> problem when reading this in a description box, if displayed in the
>> >> >> brief description in the tree view, this is redundant information,
>> >> >> taking space of more relevant information (see first attachment
>> >> >> picture).
>> >> >>
>> >> >> This patch uses some heuristic to get rid of these and thus generally
>> >> >> improves the experience for these components:
>> >> >>
>> >> >> https://github.com/hzeller/kicad/compare/skip-redundant-name-repetition-in-tree.diff
>> >> >>
>> >> >> See second picture for an example.
>> >> >>
>> >> >> Henner.
>> >> >
>> >> >
>> >> >
>> >> >> _______________________________________________
>> >> >> Mailing list: https://launchpad.net/~kicad-developers
>> >> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> >> >> Unsubscribe : https://launchpad.net/~kicad-developers
>> >> >> More help   : https://help.launchpad.net/ListHelp
>> >> >
>> >> >
>> >> > --
>> >> > Chris
>> >> >
>> >> > _______________________________________________
>> >> > Mailing list: https://launchpad.net/~kicad-developers
>> >> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> >> > Unsubscribe : https://launchpad.net/~kicad-developers
>> >> > More help   : https://help.launchpad.net/ListHelp
>> >
>> > _______________________________________________
>> > Mailing list: https://launchpad.net/~kicad-developers
>> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> > Unsubscribe : https://launchpad.net/~kicad-developers
>> > More help   : https://help.launchpad.net/ListHelp
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


References