kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

Hi,

clang gives this warning a couple times:

[ 45%] Building CXX object polygon/CMakeFiles/polygon.dir/math_for_graphics.cpp.o
/home/cmp/git/kicad/polygon/math_for_graphics.cpp:71:39: warning: using integer absolute value function 'abs' when argument is of floating point type [-Wabsolute-value]
                    *dist = std::min( abs( a - xi ), abs( a - xf ) );
                                      ^
/home/cmp/git/kicad/polygon/math_for_graphics.cpp:71:39: note: use function 'std::abs' instead
                    *dist = std::min( abs( a - xi ), abs( a - xf ) );
                                      ^~~
                                      std::abs

Can someone familiar with that section have a look and see if that is 
indeed the desired behavior? I'm thinking this will cause some rounding 
errors in potentionally subtle places.

--
Chris