kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

On 6/26/2015 10:56 AM, jp charras wrote:
> Le 26/06/2015 16:11, LordBlick a écrit :
>> In response to a message written on 26.06.2015, 14:57, from Wayne
>> Stambaugh:
>>>> It uses HTML to render the report - so when we generate the HTML we
>>>> need to
>>>> take the system background color into account separately. I'm
>>>> wondering if
>>>> the DRC report widget takes it into account.
>>>>
>>>> Tom
>>>>
>>>
>>> That's probably it.  LordBlick, is the background of the DRC and ERC
>>> report
>>> widgets white on your system?
>> As seen in first attachment very nice for any long time working eyes -
>> dark. ;)
>> Just text color does not work for the benefit of readability. IMO the basic
>> colors (background and base text color) can be read from any entry widget's
>> style above.
>>
>>> If so then I'm not sure what the best solution would be.  I guess we
>>> could
>>> use wxSystemSettings::GetColour() to fetch the wxSYS_COLOUR_WINDOW
>>> color and
>>> set the HTML widget background color accordingly but it may make the
>>> colored
>>> text difficult to see.
>> Any other colored text of course exuding black on black background, will
>> be no
>> problem (simulation in second attached file).
>> Additionally that can be solved by searching in config dir for
>> pcbnew.css with
>> known  html DOM ids and classes names, which is easy editable in Notepad
>> and any
>> scripting language - in example Python… ;)
> 
> 
> AFAIK, DRC reports use only default settings, and just basic font
> attributes:
> normal
> gold italic
> gold+italic
> 
> For most of cases, this is enough.
> Changing the size can help.
> 
> The fact in an HTML window, the background color is the background color
> system, but the foreground is not the foreground system is strange, and
> should be fixed or at least understood before creating any other dialog
> to choose colors or anything else.
> 
> Changing the font color is not mandatory.
> In the early times of Kicad, I used to change the font colors in
> messages and dialogs.
> But it created many issues with themes (on all systems), and since a
> long time we always keep the default color settings.
> 

OK, I see now said the blind man.  The ERC and DRC dialogs use
wxListCtrl not wxHtmlWindow.  That explains the difference.  It still
would be nice if the background of the wxHtmlWindow matched the
background of other text based controls.  Although, the colored text may
get lost in some background colors.