kicad-developers team mailing list archive

[Simon Richter <Simon.Richter@xxxxxxxxxx>]

Hi,

it seems not everyone is linking against our special wxWidgets, so
people are still seeing crashes from the pin table.

I think we can live with the automatic scrollbar (which works because it
is enabled when the data view model is attached to the data view, which
is sufficiently long after construction that the object is indeed complete.

   Simon

commit 8d88ec9ff1e401c15bb1af662a0fe0b7475b2401
Author: Simon Richter <Simon.Richter@xxxxxxxxxx>
Date:   Mon Jul 6 00:53:05 2015 +0200

    pin table: do not set vscroll by default to avoid crash on MacOS

diff --git a/eeschema/dialogs/dialog_lib_edit_pin_table_base.cpp b/eeschema/dialogs/dialog_lib_edit_pin_table_base.cpp
index 7c37307..3e82df5 100644
--- a/eeschema/dialogs/dialog_lib_edit_pin_table_base.cpp
+++ b/eeschema/dialogs/dialog_lib_edit_pin_table_base.cpp
@@ -16,7 +16,7 @@ DIALOG_LIB_EDIT_PIN_TABLE_BASE::DIALOG_LIB_EDIT_PIN_TABLE_BASE( wxWindow* parent
 	wxBoxSizer* top_sizer;
 	top_sizer = new wxBoxSizer( wxVERTICAL );
 	
-	m_Pins = new wxDataViewCtrl( this, wxID_ANY, wxDefaultPosition, wxSize( -1,-1 ), wxDV_HORIZ_RULES|wxDV_MULTIPLE|wxDV_ROW_LINES|wxDV_VERT_RULES|wxVSCROLL );
+	m_Pins = new wxDataViewCtrl( this, wxID_ANY, wxDefaultPosition, wxSize( -1,-1 ), wxDV_HORIZ_RULES|wxDV_MULTIPLE|wxDV_ROW_LINES|wxDV_VERT_RULES );
 	m_Pins->SetMinSize( wxSize( 400,400 ) );
 	
 	top_sizer->Add( m_Pins, 1, wxALL|wxEXPAND, 5 );
diff --git a/eeschema/dialogs/dialog_lib_edit_pin_table_base.fbp b/eeschema/dialogs/dialog_lib_edit_pin_table_base.fbp
index a010e01..b618c10 100644
--- a/eeschema/dialogs/dialog_lib_edit_pin_table_base.fbp
+++ b/eeschema/dialogs/dialog_lib_edit_pin_table_base.fbp
@@ -117,7 +117,7 @@
                         <property name="tooltip"></property>
                         <property name="window_extra_style"></property>
                         <property name="window_name"></property>
-                        <property name="window_style">wxVSCROLL</property>
+                        <property name="window_style"></property>
                         <event name="OnChar"></event>
                         <event name="OnDataViewCtrlColumnHeaderClick"></event>
                         <event name="OnDataViewCtrlColumnHeaderRightClick">OnColumnHeaderRightClicked</event>

Attachment: signature.asc
Description: OpenPGP digital signature