kicad-developers team mailing list archive

[Garth Corral <gcorral@xxxxxxxxx>]

> On Jul 7, 2015, at 12:41 PM, Garth Corral <gcorral@xxxxxxxxx> wrote:
> 
>> 
>> On Jul 7, 2015, at 12:39 PM, jp charras <jp.charras@xxxxxxxxxx> wrote:
>> 
>> Le 07/07/2015 21:26, Garth Corral a écrit :
>>> 
>>>> On Jul 7, 2015, at 12:10 PM, Garth Corral <gcorral@xxxxxxxxx> wrote:
>>>> 
>>>> 
>>>>> On Jul 7, 2015, at 10:53 AM, jp charras <jp.charras@xxxxxxxxxx> wrote:
>>>>> 
>>>>> Le 05/07/2015 23:39, Garth Corral a écrit :
>>>>>> 
>>>>>>> On Jun 22, 2015, at 10:54 AM, Andy Peters <devel@xxxxxxxxx> wrote:
>>>>>>> 
>>>>>>> 
>>>>>>>> On Jun 22, 2015, at 5:00 AM, Johannes Maibaum <jmaibaum@xxxxxxxxx> wrote:
>>>>>>>> 
>>>>>>>> Hey OSX devs,
>>>>>>>> 
>>>>>>>> And I just came across another minor UI glitch in pcbnew: When running the DRC, the dialog
>>>>>>>> window loses focus to the main window after the checks are finished. Since the main window is
>>>>>>>> usually bigger than the DRC dialog window this results in the dialog suddenly vanishing from
>>>>>>>> the screen. An unexperienced user might think that the checks failed and might try to click
>>>>>>>> the DRC button again. But since the dialog is still lurking behind the main window, nothing
>>>>>>>> happens.
>>>>>>>> 
>>>>>>>> I think that there are two issues here, that both should be easy to fix:
>>>>>>>> 
>>>>>>>> - DRC dialog window should keep focus after checks are finished.
>>>>>>>> - If the dialog has somehow lost focus (perhaps the user deliberately gave focus back to the
>>>>>>>> main window, leaving the dialog open), the next click on the DRC button/icon should bring the
>>>>>>>> dialog back to focus.
>>>>>>>> 
>>>>>>>> However, with the DRC issue I am not sure, if this is OSX only and I have no Linux machine
>>>>>>>> near me now to verify.
>>>>>>> 
>>>>>>> I have noticed this, too, and it’s been a long-standing annoyance. Is this an OS X-only issue or does it affect all platforms.
>>>>>>> 
>>>>>> Here’s my craptastic workaround for these issues.  I’ve ifdef’d some of this but it’s probably harmless on other platforms.
>>>>>> 
>>>>>> It should come as a s surprise to no one that these are the result of OS X wxWidgets issues.  The wxWidgets bug tracker is littered with variants of these, some of which were ostensibly fixed, while others have languished for years.  I have a minimal repro for both so I’ll file bugs there.  I wouldn’t expect to see a fix on the 3.0 branch any time soon.  I have a wxWidgets patch that is slightly less lame, but it still just works around the real issue so it’s probably not worth maintaining a yet another wxWidgets patch for that.
>>>>>> 
>>>>>> 
>>>>>> Garth
>>>>>> 
>>>>> 
>>>>> Garth,
>>>>> 
>>>>> Can you test the rev 5892, and mainly the DRC dialog.
>>>>> It does not include exactly your patch, because I found and fixed an
>>>>> issue in DRC dialog on other platforms during tests.
>>>>> These changes perhaps have fixed the OSX issues.
>>>>> 
>>>> The part of my patch that you applied to dialog_shim.cpp fixes the second issue, but the rest is still the same as before.
>>>> 
>>>> Garth
>>>> 
>>>> 
>>> Here’s the patch again against head.
>>> 
>> 
>> Where is the patch ?
> 
> Sorry, let’s try that again.
> 
> <osx_dialog_z-order.patch>

Might want to hold off on that for a bit.  I’ve just notice a change in behavior of the patch applied previously to the patch applied against the latest.  I can no longer close the pcbnew window without quitting kicad entirely.  This is definitely a change from before.  Not sure what introduced this as the patch is basically unchanged.

Garth

Attachment: smime.p7s
Description: S/MIME cryptographic signature