← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] No more boost::polygon in Kicad

 

On 15 July 2015 at 02:59, Maciej Sumiński <maciej.suminski@xxxxxxx> wrote:
>
> I have pushed Tom's recent fixes that should solve the issue. I also did
> a few mistakes while merging yesterday, so I overwrote the bzr
> repository with the right version.
>

Thanks Tom and Orson. I built a fresh copy from your latest changes and the
3D viewer is snappy again. Results of zone filling etc. look fine too.

Also, looking through a diff of the PCB after I rebuilt the zones, it seems
your code is smarter than Boosts. For example, I saw in a few places
changes like

-   (xy 74.798 74.798) (xy 74.798 74.798) (xy 25.202 74.798)
+  (xy 74.798 74.798)                             (xy 25.202 74.798)

where Boost was generating repeated points and you aren't :).

After reading JP's message I played around with a few cutouts to see how it
worked for me on the latest version. The only weird thing I noticed was
when two cutouts overlapped, sometimes the zone was filled right up to the
edge of the cutout, and sometimes to a margin:

http://i.imgur.com/gtTLoBR.png

With just a single cutout, it always went right up to the edge of the
cutout. The margin is ~0.13mm, as opposed to the ~0.3mm margin between the
zone fills and the board outline. In a build of product branch r5935 with
the same cutouts, the zone always went right up to the edge of the cutout.

Cheers
Blair

References