← Back to team overview

kicad-developers team mailing list archive

[PATCH] Crash and assertion failure in dialog_print_using_printer.cpp

 

On some systems, a mismatched format string in 
dialog_print_using_printer.cpp causes an assertion failure and 
subsequent segfault. (Some wx builds seem not to mind - I couldn't 
reproduce the failure on my own system - but the bug is definitely there 
and someone shared a backtrace with me.) This patch corrects the format 
string.

--
Chris
commit 9b58718bb692c1393d7af29b8f97283a6a0fd90a
Author: Chris Pavlina <cpavlin1@xxxxxxxxxxxxxx>
Date:   Mon Jul 20 16:00:19 2015 -0400

    Fix assertion in format string

diff --git a/eeschema/dialogs/dialog_print_using_printer.cpp b/eeschema/dialogs/dialog_print_using_printer.cpp
index 6fbb0ac..f6ae16c 100644
--- a/eeschema/dialogs/dialog_print_using_printer.cpp
+++ b/eeschema/dialogs/dialog_print_using_printer.cpp
@@ -433,7 +433,7 @@ void SCH_PRINTOUT::DrawPage( SCH_SCREEN* aScreen )
     FitThisSizeToPaper( pageSizeIU );
     fitRect = GetLogicalPaperRect();
 
-    wxLogDebug( wxT( "Fit rectangle: %d, %d, %d" ),
+    wxLogDebug( wxT( "Fit rectangle: x = %d, y = %d, w = %d, h = %d" ),
                   fitRect.x, fitRect.y, fitRect.width, fitRect.height );
 
     // When is the actual paper size does not match the schematic page

Follow ups