← Back to team overview

kicad-developers team mailing list archive

DLL export of PNS_TOOL_BASE

 

Hi,

the MSVC build complains:

pcbnew\router\pns_tool_base.h(37) : warning C4275: non dll-interface
class 'TOOL_INTERACTIVE' used as base for dll-interface class
'PNS_TOOL_BASE'
include\tool/tool_interactive.h(35) : see declaration of 'TOOL_INTERACTIVE'
pcbnew\router\pns_tool_base.h(36) : see declaration of 'PNS_TOOL_BASE'

I can see the point here -- if the base class is not exported, any
functions not overridden in the derived class cannot be imported if the
class is used through the DLL interface.

Is the PNS router actually meant to be used via a DLL interface though,
or can the DLL export for PNS_TOOL_BASE and derived classes be dropped?

If it is, shouldn't the TOOL_INTERACTIVE and TOOL_BASE classes be
exported as well?

   Simon

Attachment: signature.asc
Description: OpenPGP digital signature


Follow ups