kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

Okay - if I am going to add an infinite undo/redo, what is your 
preference for the default? I was going to use 50, but I think that 
infinite might be a decent choice these days. I do not think the 
undo/redo structures use very much RAM at all.

On Mon, Aug 03, 2015 at 11:53:18AM -0400, Wayne Stambaugh wrote:
> Since it's a refinement to an existing feature (undo) and the risk is
> low that there will be any issues, go ahead and make the change and I
> will commit it.  It looks like we have some time since there are a few
> segfault bugs that need to be addressed.  You may also want to make an
> undo value of zero be infinite undo/redo.
> 
> On 8/3/2015 8:07 AM, Chris Pavlina wrote:
> > Good point. I think I'll prepare a patch, then, that adds to both 
> > eeschema and pcbnew an option in the preferences dialog: "Maximum number 
> > of undo items", which defaults to 50 and can be set to any positive 
> > integer. Up to you and Wayne, of course, whether you'd rather hold onto 
> > it until after the stable release (I'm fine with that), but I would 
> > definitely like to see this changed in the near future.
> > 
> > On Mon, Aug 03, 2015 at 02:02:42PM +0200, jp charras wrote:
> >> Le 03/08/2015 13:38, Chris Pavlina a écrit :
> >>> It seems I'm not the only one who occasionally finds the undo stack size 
> >>> limit of ten to be, er, limiting. Would anyone object to raising this 
> >>> limit to something like fifty? I can't see any place where that is 
> >>> likely to cause issues, and the data doesn't use very much memory.
> >>>
> >>> --
> >>> Chris
> >>
> >> There is not technical reason to limit the undo stack to 10.
> >> It can be increased to a larger value.
> >>
> >> However if it is increased, developers need an user option (the best for
> >> me is a choice in config setup) to set this limit to a lower value when
> >> debugging/testing kicad.
> >>
> >> Why?
> >>
> >> Just because some bugs hard to find can be seen only when the undo stack
> >> reaches this limit.
> >> When this limit is reached, items in undo stack are actually deleted.
> >> And bugs like double deletion or a pointer to deleted items can be seen
> >> only when the limit is reached.
> >>
> >>
> >> -- 
> >> Jean-Pierre CHARRAS
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp
> > 
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> > 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp