kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

On 8/5/2015 10:41 AM, Maciej Sumiński wrote:
> On 08/05/2015 04:39 PM, Wayne Stambaugh wrote:
>> On 8/5/2015 10:16 AM, Maciej Sumiński wrote:
>>> Chris has pointed out that it was already discussed [1] and the change
>>> was not entirely clear. Apparently it had not been wrapped before
>>> revision 5834, so maybe OnPgmExit() should be still called for both
>>> Python and non-Python versions of pcbnew?
>>
>> This was done because the problem did not occur when wxPython scripting
>> was disabled and Dick is planning on add wxPython on top of Kicad rather
>> than a bolted onto the side like our current implementation.
>> Compiling OnPgmExit() out of non wxPython builds was at his request.
>> The original crash had to do with wxPython clean up not being called
>> properly.  I just tried to duplicate this bug on a 32 bit build on
>> windows by running 'pcbnew foo` with no scripting enabled, and I cannot
>> get it to crash.  Are you testing this on Linux?
> 
> Yes, but please try with a file with invalid contents, so there is an
> IO_ERROR exception thrown.

Tried that too, no difference.  I cannot get pcbnew to crash.  It just
pops up a dialog complaining about the parse error and exits normally as
I expect.  I'll take a look at this on Linux tonight when I get home.

> 
> Regards,
> Orson
> 
>>>
>>> Regards,
>>> Orson
>>>
>>> 1.
>>> https://www.mail-archive.com/kicad-developers@xxxxxxxxxxxxxxxxxxx/msg14014.html
>>>
>>> On 08/05/2015 11:22 AM, Maciej Sumiński wrote:
>>>> Pcbnew without scripting support crashes when run with an invalid file
>>>> given as a parameter (stack overflow in ~wxSingleInstanceChecker()).
>>>>
>>>> There is a fix for that, but wrapped with #ifdef
>>>> KICAD_SCRIPTING_WXPYTHON .. #endif. I removed the mentioned directives
>>>> and it seems fine here, but I am not confident enough to commit it
>>>> immediately. Any thoughts?
>>>>
>>>> Regards,
>>>> Orson
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
> 
>