kicad-developers team mailing list archive

[David Novak <David.Novak@xxxxxxxxx>]

Wayne,

Ok. I will work on it and resubmit.

David


On 8/12/2015 9:56 AM, Wayne Stambaugh wrote:
> David,
>
> How did you generate your patch file?  I doesn't look like a unified
> diff format to me.  The easiest way to generate a unified diff is use
> Bazaar or git to create a development branch on your system, make your
> changes, then generate you diff by running bzr diff or git diff.  Also,
> please read the KiCad coding policy, you used tabs instead of spaces for
> indenting, I see a bunch of trailing white space left behind by your
> editor, and the preferred maximum line length is 100 characters.
>
> Cheers,
>
> Wayne
>
>
> On 8/11/2015 9:39 AM, David Novak wrote:
> > We were required to make the following changes to the GenCAD exporter
> > after our contract manufacturer rejected the exported GenCAD file.
> >
> >    * Don't make new shape for every reference designator. Instead, create
> >      shapes based on modules and assign to devices based on reference
> >      designators.
> >    * Don't allow pins without numbers to have duplicate pin numbers.
> >    * Correctly implement MIRRORX.
> >    * Correctly implement flip.
> >
> > I've attached the only file that was modified. Additionally, I've
> > attached a patch file.
> >
> > Best Regards,
> > David
> >
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

--

David Novak

Dajac Inc.
317-608-0500 ext. 112

www.Dajac.com
David.Novak@xxxxxxxxx

This electronic message contains information which may be legally 
confidential and/or privileged. The information is intended solely for 
the individual or entity named above and access by anyone else is 
unauthorized. If you are not the intended recipient, any disclosure, 
copying, distribution, or use of the contents of this information is 
prohibited and may be unlawful. If you have received this electronic 
transmission in error, please reply immediately to the sender that you 
have received the message in error, and delete it. Thank you.