← Back to team overview

kicad-developers team mailing list archive

Re: PATCH: fix broken workflows due to recent changes in IDF exporter

 

Hi to all,

would it be possible to commit Cirilo's patch?

thank you
Maurice

On 15/08/2015 01.48, Cirilo Bernardo wrote:
OK, once more ...
The attached patch (export_idf_20150815_B.patch) adds an option
for the legacy Grid Reference behavior of the IDF exporter. I believe
that this time I am using the wxWidgets events dispatcher as
intended so the code should not only be prettier but it should also
work correctly.

Please test and report success or problems.

I've tested on Debian Linux and it works for me.

- Cirilo


On Fri, Aug 14, 2015 at 10:04 PM, easyw <easyw@xxxxxxxxxxxx> wrote:

Hi Cirilo,

I tried the patch in windows 8 64, and I have the following problems:
if I click to Auto Adjust,
1. I got not only X,Y ref and Units disabled but also the other objects in
the dialog and the check box remains unchecked
(I cannot click on OK, Cancel until I click to kicad main window, not the
dialog nor the pcbnew)
3. after retrning to the dialog I can click OK, but the export still
consider X,Y ref values...

I forced in dialog_export_idf.cpp the option to get
    GetBoard()->ComputeBoundingBox( true );
to simulate the Auto Adjust checked,
then the export returns to the standard old way...

thank you for support
Maurice


On 14/08/2015 10.32, Cirilo Bernardo wrote:

The attached patch adds an option to use a user-specified grid reference
for the IDF export (new behavior) or an automatically calculated reference
point (legacy behavior). This change was made to accommodate requests
for the legacy behavior; apparently my new improved features have broken
people's workflows again. :)

- Cirilo



_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp





References