kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Mario,

I committed your patch to the product branch r6119.  Thank you for your
contribution to KiCad.

Cheers,

Wayne

On 8/24/2015 3:54 AM, Tomasz Wlostowski wrote:
> On 23.08.2015 21:59, Mário Luzeiro wrote:
>> Hello Tomasz,
>>
>> I made some additions to the shape_poly_set library. I appreciate if
>> you can have a look in the additions and if you agree with that to
>> commit it to trunk. There are no changes related with current used
>> source in the trunk so should be no problem ( I am just using it in
>> my branch at the moment)
> Hi Mario,
> 
> Thanks from the patch. Wayne, could you commit it?
>>
>> I implemented the "HoleCount" function but I had a little difficult
>> to understand it in the beginning so you may want give more attention
>> in that one.
> 
> It's OK.
> 
>>
>> I fix a little error in the Function booleanOp documentation header. 
>> Also I was looking for the propose of the aFastMode ( JP added it
>> related with 3d viewer? to make it faster ), I was thinking that (in
>> my case) it is important the really mean of the result of the
>> "aFastMode" (i.e: weak or strictly polygon) so maybe we should name
>> it by the real propose?
> 
> Feel free to change that too and send a patch.
> 
> Cheers,
> Tom
>