kicad-developers team mailing list archive

[Blair Bonnett <blair.bonnett@xxxxxxxxx>]

Hi all,

Just compiling the latest revision and GCC gave a warning I hadn't seen in
the code before:

pcbnew/router/pns_shove.cpp: In member function ‘PNS_SHOVE::SHOVE_STATUS
PNS_SHOVE::processHullSet(PNS_LINE&, PNS_LINE&, PNS_LINE&, const
HULL_SET&)’:
pcbnew/router/pns_shove.cpp:155:10: warning: variable ‘failingDirCheck’ set
but not used [-Wunused-but-set-variable]

In r6105 the return of this function was changed from
    return failingDirCheck ? SH_OK : SH_INCOMPLETE;
to
    return SH_INCOMPLETE;

So failingDirCheck is initialised on line 155, and set in a conditional on
line 210, but is no longer actually used. Can the variable be deleted to
get rid of the warning (and potential confusion for somebody reading the
code further down the track)?

Blair