← Back to team overview

kicad-developers team mailing list archive

Re: PATCH: DXF Import: add option to align DXF origin to PCB grid point

 

Thanks Wayne,

 The positioning options are much clearer now. We have one more happy
KiCad user:

https://forum.kicad.info/t/how-do-you-create-edge-cut-lines/1196/10

- Cirilo

On Fri, Aug 28, 2015 at 4:13 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx>
wrote:

> Cirilo,
>
> I committed this patch along with some improvements to the dialog box.
> I improved upon you naming suggestions below because the original
> wording was confusing.  I also made the OK button the default per the UI
> policy and improved overall layout of the dialog box.
>
> Thanks,
>
> Wayne
>
> On 8/25/2015 11:21 PM, Cirilo Bernardo wrote:
> > This patch adds an option to set the imported DXF origin to
> > a specified point on the PCB grid. This feature is useful for
> > people who must use a board outline in DXF format which
> > was provided by some MCAD system since it allows the
> > user to place the DXF origin at a convenient known location;
> > it essentially offers many more possibilities than the
> > current placement options. The patch was generated against
> > rev 6127.
> >
> > Additional comments:
> >
> > 1. In the OpenGAL renderer, the outline is grabbed after it
> > is created from the DXF data. Is this deliberate or should
> > the outline not be grabbed/selected as in the case of the
> > default renderer?
> >
> > 2. I suggest renaming the placement options. At the
> > moment they are:
> >
> > a. Right Top Corner: incorrect since the DXF origin is
> > placed at the "Top Left"
> > b. Middle: it is confusing what is meant by "middle",
> > so I suggest "Center Left"
> > c. Centered on page: I suggest "Center of Page"
> > d. Right Bottom Corner: I suggest "Bottom Right".
> >
> > I was hesitant to make the changes I suggest to
> > the text in the position options, which is why I put
> > the suggestion here rather than as part of the patch.
> >
> > - Cirilo
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

References