kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #20050
[PATCH] Git hub URL bug
Attached patch provides following changes:
- remove translatability Github URL as pointless.
- change it to secure and working address.
--
Best Regards,
LordBlick
--- pcbnew/dialogs/wizard_add_fplib_base.cpp.old 2015-08-29 08:02:38.1440828158
+++ pcbnew/dialogs/wizard_add_fplib_base.cpp 2015-08-30 10:52:19.1440924739
@@ -46,7 +46,7 @@
m_radioAddGithub = new wxRadioButton( m_wizPage1, wxID_ANY, _("Github repository"), wxDefaultPosition, wxDefaultSize, 0 );
m_githubSizer->Add( m_radioAddGithub, 0, wxALL|wxEXPAND, 5 );
- m_textCtrlGithubURL = new wxTextCtrl( m_wizPage1, wxID_ANY, _("http://github.com/KiCad"), wxDefaultPosition, wxDefaultSize, 0 );
+ m_textCtrlGithubURL = new wxTextCtrl( m_wizPage1, wxID_ANY, "https://github.com/KiCad", wxDefaultPosition, wxDefaultSize, 0 );
m_textCtrlGithubURL->SetMinSize( wxSize( 300,-1 ) );
m_githubSizer->Add( m_textCtrlGithubURL, 1, wxALL|wxEXPAND, 5 );
--- pcbnew/dialogs/wizard_3DShape_Libs_downloader_base.cpp.old 2015-08-29 08:02:38.1440828158
+++ pcbnew/dialogs/wizard_3DShape_Libs_downloader_base.cpp 2015-08-30 10:52:19.1440924739
@@ -36,7 +36,7 @@
m_staticText8->Wrap( -1 );
bSizer19->Add( m_staticText8, 0, wxTOP|wxRIGHT|wxLEFT, 5 );
- m_textCtrlGithubURL = new wxTextCtrl( m_wizPage1, wxID_ANY, _("http://github.com/KiCad"), wxDefaultPosition, wxDefaultSize, 0 );
+ m_textCtrlGithubURL = new wxTextCtrl( m_wizPage1, wxID_ANY, "https://github.com/KiCad", wxDefaultPosition, wxDefaultSize, 0 );
m_textCtrlGithubURL->SetMinSize( wxSize( 300,-1 ) );
bSizer19->Add( m_textCtrlGithubURL, 0, wxALL|wxEXPAND, 5 );
Follow ups