← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Add axis origin marker to Footprint Editor

 

Sorry, that's an old artifact - to be remove before commit. Sorry for
the confusion!

Best Regards,

Brian.

On 4 September 2015 at 08:44, Mark Roszko <mark.roszko@xxxxxxxxx> wrote:
> Why are you doing this:
>
> switch( m_style & 0xFF )
>
> Why is that necessary when the default case should handle any invalid
> values? Especially because the enum MARKER_STYLE has no assigned values
> nor really is a bitmasking type of enum.
>
> On Thu, Sep 3, 2015 at 5:37 PM, Brian Sidebotham
> <brian.sidebotham@xxxxxxxxx> wrote:
>> To match functionality of the Legacy canvas I propose we extend the
>> GAL ORIGIN_VIEWITEM class to allow us to add an axis origin marker
>> when using the Footprint Editor. I'm sure even while in the stable
>> feature-lock this is okay to commit, but an ack will be good before I
>> go ahead.
>>
>> Also, Orson, thanks for your information about this, can you also ack
>> that you're happy with the class extension? Otherwise feel free to
>> contact me to implement this in another way if you'd rather...
>>
>> Best Regards,
>>
>> Brian.
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
>
>
> --
> Mark


References