kicad-developers team mailing list archive

[Brian Sidebotham <brian.sidebotham@xxxxxxxxx>]

On 4 September 2015 at 09:29, Maciej Sumiński <maciej.suminski@xxxxxxx> wrote:
> On 09/03/2015 11:37 PM, Brian Sidebotham wrote:
>> To match functionality of the Legacy canvas I propose we extend the
>> GAL ORIGIN_VIEWITEM class to allow us to add an axis origin marker
>> when using the Footprint Editor. I'm sure even while in the stable
>> feature-lock this is okay to commit, but an ack will be good before I
>> go ahead.
>>
>> Also, Orson, thanks for your information about this, can you also ack
>> that you're happy with the class extension? Otherwise feel free to
>> contact me to implement this in another way if you'd rather...
>
> Hi Brian,
>
> I was about to point out the same things as Jon, but I already know the
> reasons. Apart from that, I would introduce two minor modifications:
>
> - increase the m_axisOrigin size to a high value (e.g. 20000), so the
> axis lines span across the editor window even on high resolution screens
> (unless it is intentional to keep it this size)
>
> - if it is supposed to be displayed only in the footprint editor, then
> it might be moved from PCBNEW_CONTROL to MODULE_TOOLS class
>
> The rest looks fine to me. Thank you!
>
> Regards,
> Orson
>

Thanks Orson. I will move it to MODULE_TOOLS (and therefore remove
EditModules() from PCBNEW_CONTROL again) as it is footoprint editor
specific - sorry I didn't see it had it's own toolset.

Thanks for the feedback guys.

Best Regards,

Brian.