← Back to team overview

kicad-developers team mailing list archive

[PATCH 1/2] Last argument before ellipsis may not be reference

 

The C++ specification disallows this to permit implementations that use
the address-of operator and sizeof to calculate the address of the first
argument inside the ellipsis; sizeof(foo &) gives the size of the "foo"
class rather than the space taken up by the reference.
---
 pcbnew/specctra.cpp | 2 +-
 pcbnew/specctra.h   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/pcbnew/specctra.cpp b/pcbnew/specctra.cpp
index 2358d3b..20d4ff3 100644
--- a/pcbnew/specctra.cpp
+++ b/pcbnew/specctra.cpp
@@ -132,7 +132,7 @@ int SPECCTRA_DB::findLayerName( const std::string& aLayerName ) const
 }
 
 
-void SPECCTRA_DB::ThrowIOError( const wxString& fmt, ... ) throw( IO_ERROR )
+void SPECCTRA_DB::ThrowIOError( const char* fmt, ... ) throw( IO_ERROR )
 {
     wxString    errText;
     va_list     args;
diff --git a/pcbnew/specctra.h b/pcbnew/specctra.h
index 540fcf9..7284d8e 100644
--- a/pcbnew/specctra.h
+++ b/pcbnew/specctra.h
@@ -3919,7 +3919,7 @@ public:
      */
     void LoadSESSION( const wxString& filename ) throw( IO_ERROR, boost::bad_pointer );
 
-    void ThrowIOError( const wxString& fmt, ... ) throw( IO_ERROR );
+    void ThrowIOError( const char* fmt, ... ) throw( IO_ERROR );
 
     /**
      * Function ExportPCB

Follow ups