← Back to team overview

kicad-developers team mailing list archive

Re: Rev 6210: Unify help menus across top level windows.

 

Patch in attachment.

2015-09-30 15:49 GMT+03:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:

> Please include your patch as an attachment.  Bzr doesn't really handle
> inline email patches gracefully so it makes my life easier if you just
> attach the patch.
>
> Thanks,
>
> Wayne
>
> On 9/30/2015 4:36 AM, Константин Барановский wrote:
> > The separator are missed in help menu over info entry in pl_editor and
> > gerbview.
> >
> >
> > === modified file 'gerbview/menubar.cpp'
> > --- gerbview/menubar.cpp2015-09-29 08:57:58 +0000
> > +++ gerbview/menubar.cpp2015-09-30 08:22:13 +0000
> > @@ -231,6 +231,9 @@
> >                   _( "Open \"Getting Started in KiCad\" guide for
> > beginners" ),
> >                   KiBitmap( online_help_xpm ) );
> >
> > +    // Separator
> > +    helpMenu->AppendSeparator();
> > +
> >      // About Kicad
> >      AddMenuItem( helpMenu,
> >                   wxID_ABOUT,
> >
> > === modified file 'pagelayout_editor/menubar.cpp'
> > --- pagelayout_editor/menubar.cpp2015-09-29 08:57:58 +0000
> > +++ pagelayout_editor/menubar.cpp2015-09-30 08:21:58 +0000
> > @@ -158,6 +158,9 @@
> >                   _( "Open \"Getting Started in KiCad\" guide for
> > beginners" ),
> >                   KiBitmap( online_help_xpm ) );
> >
> > +    // Separator
> > +    helpMenu->AppendSeparator();
> > +
> >      // About Kicad
> >      AddMenuItem( helpMenu,
> >                   wxID_ABOUT,
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
=== modified file 'gerbview/menubar.cpp'
--- gerbview/menubar.cpp	2015-09-29 08:57:58 +0000
+++ gerbview/menubar.cpp	2015-09-30 08:22:13 +0000
@@ -231,6 +231,9 @@
                  _( "Open \"Getting Started in KiCad\" guide for beginners" ),
                  KiBitmap( online_help_xpm ) );
 
+    // Separator
+    helpMenu->AppendSeparator();
+
     // About Kicad
     AddMenuItem( helpMenu,
                  wxID_ABOUT,

=== modified file 'pagelayout_editor/menubar.cpp'
--- pagelayout_editor/menubar.cpp	2015-09-29 08:57:58 +0000
+++ pagelayout_editor/menubar.cpp	2015-09-30 08:21:58 +0000
@@ -158,6 +158,9 @@
                  _( "Open \"Getting Started in KiCad\" guide for beginners" ),
                  KiBitmap( online_help_xpm ) );
 
+    // Separator
+    helpMenu->AppendSeparator();
+
     // About Kicad
     AddMenuItem( helpMenu,
                  wxID_ABOUT,

Follow ups

References