kicad-developers team mailing list archive

[jp charras <jp.charras@xxxxxxxxxx>]

Le 21/10/2015 03:09, Henner Zeller a écrit :
> On 20 October 2015 at 13:49, Henner Zeller <h.zeller@xxxxxxx> wrote:
>> On 20 October 2015 at 13:17, Nick Østergaard <oe.nick@xxxxxxxxx> wrote:
>>> I think the proposed naming makes sense. I don't think we need to mark
>>> it as deprecated, we could just remove it. I have not heard of a lot
>>> of users that have discovered the python API, so I think the impact of
>>> removing it when we have not yet made the stable release yet is very
>>> limited.
>>
>> Also, it didn't work since JP submitted the patch :) So, yes, we should
>> probably rename it immediately with no deprecation period.
> 
> Ok, suggested patch here:
> 
> https://github.com/hzeller/kicad/compare/master...hzeller:rename-to-protel-extensions.diff
> 
> Also includes a call to set this property in the sample script, so
> that it is discoverable (with value 'False',
> so behavior of existing script doesn't change).
> 
> Suggested commit message:
> ------------
> Rename {Set,Get}GerberExtensions() to {Set,Get}GerberProtelExtensions()
> in public API.
> ------------
> 
> -h

This is a better name.
Committed. Thanks.


-- 
Jean-Pierre CHARRAS