kicad-developers team mailing list archive

[Mário Luzeiro <mrluzeiro@xxxxx>]

Hi JP,

I am not necessarily forcing related it is as a fault from other modules in kicad. But maybe because of any special nature of the polygons from bitmap2component it was causing the issue from that data. (see note*)
The issue I found in the Clipper is that it was not generate the right polygons after run run the kicad function "simplify". I extract the polygon data,plot it and notice that the polygons are broken, i.e: not correct and not as expected.
Then I checked Clipper repository and there was this commit:
http://sourceforge.net/p/polyclipping/code/495/
"Significant bugfix potentially affecting all clipping ops."
I then applied the latest version to my branch and it solved the issue I had.

I notice your commit today, I plan to check it and test it latter today!
Thanks!
Mario

* However, I notice that some polygons have repeated values (special in the latest two positions) but the Append function implemented in Kicad is eliminate this duplication when the data is converted to Clipper.
Maybe a good thing will be to have a clear / checking the polygons in the origin for more correctness.

________________________________________
From: Kicad-developers [kicad-developers-bounces+mrluzeiro=ua.pt@xxxxxxxxxxxxxxxxxxx] on behalf of jp charras [jp.charras@xxxxxxxxxx]
Sent: 02 November 2015 12:01
To: kicad-developers@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Kicad-developers] Clipper bugs fixes, suggest for update

Le 01/11/2015 14:15, Mário Luzeiro a écrit :
> Hello,
>
> During some tests I did (in my branch and related with 3d-viewer) I experienced some issues that I found to be related with Clipper.
>
> I updated it to latest head and it solve the bugs:
> http://sourceforge.net/p/polyclipping/code/HEAD/tree/trunk/
>
> Latest version is:
> Version   :  6.4.0
> Date      :  2 July 2015
>
> Kicad current version is:
> Version   :  6.2.1
> Date      :  31 October 2014
>
>
> I found also  that most of the issues are related with polygons that come from "bitmap 2 component" vectorial conversion.

Could you explain what issues your have encountered?

About polygons that come from "bitmap 2 component", I just fixed a bug
in polygon calculation, only used in these footprints having polygons.

This bugged code was used only in 3D viewer, and perhaps the issues you
encountered was not due to Clipper.

Of course, updating Clipper can be considered.

--
Jean-Pierre CHARRAS

_______________________________________________
Mailing list: https://launchpad.net/~kicad-developers
Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp