← Back to team overview

kicad-developers team mailing list archive

Re: packages3d fix for OS X

 

Actually, Wayne, hold off on any of these patches, I may be able to fix
this in the nightly/release packaging scripts with a symlink.

I will keep in touch!

Adam Wolf
On Nov 19, 2015 1:59 PM, "Wayne Stambaugh" <stambaughw@xxxxxxxxx> wrote:

> None that wouldn't require a bunch of code changes which at this point
> is a no go.  I can commit your second patch that handles either install
> path for packages3d.  This should work on new installs and folks who are
> brave enough to build and install from source on OSX.  Any changes
> beyond that we should shelve until after the stable release.  Let me
> know if this makes sense and I will commit the patch.
>
> Wayne
>
> On 11/19/2015 1:29 PM, Adam Wolf wrote:
> > Do you have any ideas on how to make it work for the release?
> >
> > Adam Wolf
> >
> >
> > On Thu, Nov 19, 2015, 12:18 PM Wayne Stambaugh <stambaughw@xxxxxxxxx
> > <mailto:stambaughw@xxxxxxxxx>> wrote:
> >
> >     It sounds like this is going to break the existing behavior so I
> would
> >     rather wait until after the stable release unless we can guarantee
> that
> >     it will continue to work on existing installs.
> >
> >     Moving forward, it probably makes more sense to install the 3D models
> >     along side the library and module paths so we end up with:
> >
> >     ${KICAD_DATA}/modules
> >     ${KICAD_DATA}/library
> >     ${KICAD_DATA}/packages3d
> >
> >     instead of:
> >
> >     ${KICAD_DATA}/modules
> >     ${KICAD_DATA}/library
> >     ${KICAD_DATA}/modules/packages3d
> >
> >     on all platforms.  Are users still using the legacy module
> libraries?  I
> >     believe they were all converted to the pretty format when the new
> file
> >     formats were implemented.  We could get rid of them as well during
> the
> >     next development cycle.
> >
> >     On 11/19/2015 10:41 AM, Adam Wolf wrote:
> >     > So originally,  I mostly forgot that people do source builds on OS
> >     X. :)
> >     >
> >     > After thinking about it, I think we need both search paths in
> >     kiface_i,
> >     > the new default in pgmbase, and the docs changed.  All of these
> are in
> >     > the patch on this list.
> >     >
> >     > Then we also could make the kicad-library repo put the packages3d
> the
> >     > same place that the nightlies do, which I have done and tested but
> >     it is
> >     > on git so I haven't attached the patch, but it is basically if
> apple,
> >     > install to modules/.., but if not, install to modules/.
> >     >
> >     > This should make it so new users on nightlies have a good default,
> new
> >     > users on source builds have a good default, and shouldn't impact
> old
> >     > nightly users who have preferences files already.
> >     >
> >     > It would impact current from-source users, who update
> >     kicad-library and
> >     > expect the 3D data to go into modules/packages3d.  If you have any
> >     > thoughts about how to mitigate that, or if it's something we are OK
> >     > accepting, let me know.
> >     >
> >     > I can also investigate doing this in a different way, or ignore the
> >     > issue until the 3d refactor work which will make a lot of this
> >     moot, but
> >     > it has been reported a few times in the last few months.
> >     >
> >     > Adam Wolf
> >     >
> >     >
> >     > On Thu, Nov 19, 2015, 9:29 AM Wayne Stambaugh
> >     <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
> >     > <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>>
> wrote:
> >     >
> >     >
> >     >     Adam,
> >     >
> >     >     I forgot to ask, would this change be on top of your current
> >     patch or
> >     >     replace the current patch?
> >     >
> >     >     Wayne
> >     >
> >     >     On 11/18/2015 8:49 PM, Adam Wolf wrote:
> >     >     > Slick!  Faster than I thought to make the change on a branch
> for
> >     >     > kicad-libraries.  This would make it so new from-source
> builders
> >     >     on OS X
> >     >     > install their packages3d to the same place as nightly and
> >     release
> >     >     users.
> >     >     >
> >     >     > If you think it's a good idea, I'll propose the 8 line patch
> to
> >     >     Carl and
> >     >     > the rest of the library folks.
> >     >     >
> >     >     > Adam Wolf
> >     >     > Cofounder and Engineer
> >     >     > W&L
> >     >     >
> >     >     > On Wed, Nov 18, 2015 at 7:36 PM, Adam Wolf
> >     >     > <adamwolf@xxxxxxxxxxxxxxxxxxxx
> >     <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx>
> >     >     <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx
> >     <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx>>
> >     >     <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx
> >     <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx>
> >     >     <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx
> >     <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx>>>>
> >     >     > wrote:
> >     >     >
> >     >     >     Hi Wayne,
> >     >     >
> >     >     >     Attached is the updated patch.  Do you think I should
> >     also do a
> >     >     >     patch for the library group so from-source builders on
> >     OS X will
> >     >     >     match the nightlies?  (I probably should have done this
> >     a long
> >     >     time
> >     >     >     ago actually!)
> >     >     >
> >     >     >     Adam Wolf
> >     >     >
> >     >     >     On Wed, Nov 18, 2015 at 6:31 PM, Adam Wolf
> >     >     >     <adamwolf@xxxxxxxxxxxxxxxxxxxx
> >     <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx>
> >     >     <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx
> >     <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx>>
> >     >     >     <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx
> >     <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx>
> >     >     <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx
> >     <mailto:adamwolf@xxxxxxxxxxxxxxxxxxxx>>>> wrote:
> >     >     >
> >     >     >         I can definitely add the extra search path in.  It
> >     was only
> >     >     >         meant to impact new users without preferences
> already.
> >     >     >
> >     >     >         Adam Wolf
> >     >     >
> >     >     >         On Nov 18, 2015 6:01 PM, "Wayne Stambaugh"
> >     >     <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
> >     <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>
> >     >     >         <mailto:stambaughw@xxxxxxxxx
> >     <mailto:stambaughw@xxxxxxxxx>
> >     >     <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>>>>
> >     wrote:
> >     >     >
> >     >     >             Adam,
> >     >     >
> >     >     >             Is this going to break anything for users who
> >     compile from
> >     >     >             source?  It
> >     >     >             looks as though it might.  If so, you might want
> >     to have
> >     >     >             both paths in
> >     >     >             the search list just in case.  AFAIK, the search
> >     path code
> >     >     >             removes all
> >     >     >             non-existent paths from the list.
> >     >     >
> >     >     >             Wayne
> >     >     >
> >     >     >             On 11/18/2015 3:57 PM, Adam Wolf wrote:
> >     >     >             > Hi folks,
> >     >     >             >
> >     >     >             > I'm trying to wrap up all the OS X packaging
> >     related
> >     >     bugs
> >     >     >             ASAP before
> >     >     >             > 4.0.0 drops shortly.  I got a nasty one where
> >     we weren't
> >     >     >             actually
> >     >     >             > supporting 10.8, but as of this morning I fixed
> >     >     that! (It
> >     >     >             wasn't a KiCad
> >     >     >             > code change.)
> >     >     >             >
> >     >     >             > However!
> >     >     >             >
> >     >     >             > For OS X, we put packages3d next to modules,
> >     rather than
> >     >     >             inside of it.
> >     >     >             > I think we had a pretty long discussion on
> >     this before,
> >     >     >             but basically OS
> >     >     >             > X users are trained to use installers where
> they
> >     >     drag and drop
> >     >     >             > directories into destination directories.  We
> >     have a
> >     >     Kicad
> >     >     >             Extras dmg
> >     >     >             > where we put the offline footprints and other
> >     "extras",
> >     >     >             and if we put
> >     >     >             > the packages3d inside of the stock modules/
> >     directory,
> >     >     >             when they drag
> >     >     >             > and drop the extras ones into the directory,
> it'll
> >     >     clobber
> >     >     >             them, so we
> >     >     >             > store them parallel.  I kinda mangled the
> >     explanation
> >     >     >             there, so if
> >     >     >             > someone wants clarification, I can write one
> up.
> >     >     >             >
> >     >     >             > A user reported that the default packages3d
> >     path doesn't
> >     >     >             match what we
> >     >     >             > package for OS X.
> >     >     >             (https://bugs.launchpad.net/kicad/+bug/1496214)
> >     >     >             >
> >     >     >             > I wrote a small patch to fix this, and it
> >     appears to
> >     >     >             work.  The changes
> >     >     >             > are gated for OS X, but I'd appreciate another
> eye
> >     >     on this.
> >     >     >             >
> >     >     >             > Thoughts?
> >     >     >             >
> >     >     >             > Adam Wolf
> >     >     >             > Cofounder and Engineer
> >     >     >             > W&L
> >     >     >             >
> >     >     >             >
> >     >     >             > _______________________________________________
> >     >     >             > Mailing list:
> >     https://launchpad.net/~kicad-developers
> >     >     >             > Post to     :
> >     kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
> >     >     >             <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>>
> >     >     >             > Unsubscribe :
> >     https://launchpad.net/~kicad-developers
> >     >     >             > More help   :
> https://help.launchpad.net/ListHelp
> >     >     >             >
> >     >     >
> >     >     >
> >     >     >             _______________________________________________
> >     >     >             Mailing list:
> >     https://launchpad.net/~kicad-developers
> >     >     >             Post to     :
> >     kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
> >     >     >             <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>>
> >     >     >             Unsubscribe :
> >     https://launchpad.net/~kicad-developers
> >     >     >             More help   :
> https://help.launchpad.net/ListHelp
> >     >     >
> >     >     >
> >     >     >
> >     >
> >     >     _______________________________________________
> >     >     Mailing list: https://launchpad.net/~kicad-developers
> >     >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
> >     >     Unsubscribe : https://launchpad.net/~kicad-developers
> >     >     More help   : https://help.launchpad.net/ListHelp
> >     >
> >
> >     _______________________________________________
> >     Mailing list: https://launchpad.net/~kicad-developers
> >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     Unsubscribe : https://launchpad.net/~kicad-developers
> >     More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Follow ups

References