kicad-developers team mailing list archive

[Brian Sidebotham <brian.sidebotham@xxxxxxxxx>]

I haven't had a look at the patch, but I'm a fan of libcurl and use it
quite a lot - it's been great for implementing cloud services for me.
So I'm in favour of the switch!

Best Regards,

Brian.

On 3 December 2015 at 13:28, Kristian Nielsen <knielsen@xxxxxxxxxxxxxxx> wrote:
> Mark Roszko <mark.roszko@xxxxxxxxx> writes:
>
>> I have written a replacement implementation that drops avhttp in favor
>> of libcurl.
>
> Works for me on Debian stable.
>
> And as a bonus, broken network connection now causes a timeout rather than
> an infinite hang:
>
>   Errors were encountered loading footprints
>   IO_ERROR: https://codeload.github.com/KiCad/Relays_ThroughHole.pretty/zip/master
>   Cannot get/download Zip archive: 'https://github.com/KiCad/Relays_ThroughHole.pretty'
>   for library path: 'IO_ERROR: CURL Request Failed: Timeout was reached
>
> You seem to have trailing whitespace lines in your patch, you might want to
> remove those.
>
> And you left a comment about avhttp on the function
> GITHUB_GETLIBLIST::remoteGetJSON() when you moved/renamed it, probably that
> comment should be deleted now?
>
> Thanks,
>
>  - Kristian.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp