kicad-developers team mailing list archive

[Cirilo Bernardo <cirilo.bernardo@xxxxxxxxx>]

On Sun, Dec 6, 2015 at 2:30 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx>
wrote:

> On 12/4/2015 3:51 PM, Cirilo Bernardo wrote:
> > GLM seems to have changed the names/locations of some header files
> somewhere
> > between v0.94 and 0.97. For example 0.94 has core/type_mat4x4.hpp  while
> > 0.97
> > has mat4x4.hpp + detail/type_mat4x4.hpp. The 'mat4x4.hpp' seems to be a
> new
> > file as well. I would prefer to code for the newer release; if we code
> > using the older
> > headers we're only adding unnecessary work in the future if we happen to
> > use the
> > part of the API which changed.
> >
> > I thought the GLM code may have been included because of problems on some
> > platforms; on Linux the headers are available for installation via the
> > package
> > managers and it would be easy to implement FindGLM.cmake if one doesn't
> > already exist.
>
> This would be my preference rather than keeping a copy of GLM in our
> sources.  Pick a minimum version of GLM and use it in the cmake
> find_package() call.  As of right now, libglm in Debian stable (my
> benchmark for package availability) is version 0.9.5.4.  The version of
> libglm in Debian Testing is 0.9.7.1.  Please verify libglm has a sane
> installation tool either autotools or cmake so it can easily be
> installed on Posix like systems such as msys2/mingw.
>
>
Looking at the MSYS2 packages list from April of this year:

mingw/*mingw-w64-glm* 0.9.6.3-1

So there's no problem on MSYS2. I have no idea about OSX though. At any
rate I'll look into FindGLM.cmake and come up with something if there isn't
already a package.  Going by Mario's previous email the 0.9.5 version
wouldn't have the matrix decomposition which he uses so Debian Stable
(Jessie) won't do and there doesn't seem to be a backport of 0.9.6 or
later yet, not to mention the numerous other distributions and the versions
they have, though it's hard to imagine anyone having an older version
than Debian.

- Cirilo



> >
> > - Cirilo
> >
> >
> > On Sat, Dec 5, 2015 at 4:52 AM, Mário Luzeiro <mrluzeiro@xxxxx
> > <mailto:mrluzeiro@xxxxx>> wrote:
> >
> >     Hi Wayne,
> >
> >     GLM library is already used by GAL on pcbnew so I adopted it also
> >     for 3d-viewer.
> >     The current version of the lib on kicad is 0.9.4, the official GLM
> >     release is at moment on 0.9.7.1
> >
> >     I don't remember why I updated (0.9.8) it in my branch but since I
> >     am using just some basic functions, my code should work with the
> >     stable GLM release and also with the (old) 0.9.4 version on Kicad.
> >     I will check if my code works with the current one used in kicad and
> >     let you and Orson decide if it useful to updated it or not.
> >
> >     btw, GLM is provide as an header file only library, so only need to
> >     have included the proper path to it (that kicad already have it
> working)
> >
> >     Mario
> >
> >     ________________________________________
> >     From: Kicad-developers
> >     [kicad-developers-bounces+mrluzeiro=ua.pt@xxxxxxxxxxxxxxxxxxx
> >     <mailto:ua.pt@xxxxxxxxxxxxxxxxxxx>] on behalf of Wayne Stambaugh
> >     [stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>]
> >     Sent: 04 December 2015 17:08
> >     To: kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     Subject: Re: [Kicad-developers] GLM
> >
> >     Is the GLM library a new dependency for the 3D viewer?  If so, why
> are
> >     you not using the current released version?  I do not want to be on a
> >     continuous cycle of using unreleased libraries.  In the past this has
> >     caused us a lot of grief.  This also creates maintenance headaches
> and
> >     issues for package developers.  Please consider this carefully.  I
> will
> >     reject any change that requires KiCad to build any dependencies.  If
> we
> >     cannot use FindSomeLibrary.cmake, then it's a no go as far as I'm
> >     concerned.  I'm not terribly thrilled with the libraries as source we
> >     include to get KiCad to build but that is tolerable.  I'm not going
> to
> >     take the draconian route and say I will never accept it but we need
> to
> >     think any new dependency carefully.
> >
> >     On 12/4/2015 3:49 AM, Mário Luzeiro wrote:
> >     > Hi Orson,
> >     >
> >     > Cirilo got the version from my branch and I am using it since I
> >     started my branch.
> >     > I guess there are no issues, so it maybe now a good idea (after
> >     the release) to update some libraries.
> >     > The 0.9.8 is the version of the trunk of GLM (the official in
> >     website still at 0.9.7 )
> >     > https://github.com/g-truc/glm/tree/master/glm
> >     >
> >     > Mario
> >     > ________________________________________
> >     > From: Kicad-developers
> >     [kicad-developers-bounces+mrluzeiro=ua.pt@xxxxxxxxxxxxxxxxxxx
> >     <mailto:ua.pt@xxxxxxxxxxxxxxxxxxx>] on behalf of Maciej Sumiński
> >     [maciej.suminski@xxxxxxx <mailto:maciej.suminski@xxxxxxx>]
> >     > Sent: 04 December 2015 08:37
> >     > To: Cirilo Bernardo; KiCad Developers
> >     > Subject: Re: [Kicad-developers] GLM
> >     >
> >     > Hi Cirilo,
> >     >
> >     > I do not see any obstacles. Are you already testing the new
> >     version? If
> >     > everything seems fine, then I will update it in the product branch.
> >     >
> >     > Regards,
> >     > Orson
> >     >
> >     > On 12/03/2015 10:10 PM, Cirilo Bernardo wrote:
> >     >> While looking into preparing an initial merge of the 3D refactor
> >     branch I
> >     >> noticed that kicad has the GLM v0.94.  The newer rendering code
> makes
> >     >> use of GLM v0.98.  Are there any objections to replacing GLM with
> the
> >     >> later version?
> >     >>
> >     >> - Cirilo
> >     >
> >     >
> >     >
> >     > _______________________________________________
> >     > Mailing list: https://launchpad.net/~kicad-developers
> >     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     > Unsubscribe : https://launchpad.net/~kicad-developers
> >     > More help   : https://help.launchpad.net/ListHelp
> >     >
> >
> >
> >     _______________________________________________
> >     Mailing list: https://launchpad.net/~kicad-developers
> >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     Unsubscribe : https://launchpad.net/~kicad-developers
> >     More help   : https://help.launchpad.net/ListHelp
> >     _______________________________________________
> >     Mailing list: https://launchpad.net/~kicad-developers
> >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     Unsubscribe : https://launchpad.net/~kicad-developers
> >     More help   : https://help.launchpad.net/ListHelp
> >
> >
>
>