← Back to team overview

kicad-developers team mailing list archive

Re: [patch] default kicad_common to environment variables

 

To clarify, by "results", I mean "shows up in the path manager as".  I
wonder if we're doing something later, hmm.

Adam Wolf

On Mon, Dec 7, 2015 at 11:09 AM, Adam Wolf <adamwolf@xxxxxxxxxxxxxxxxxxxx>
wrote:

> It works fine on OS X.
>
> I found a weirdess with AppendDir, however, that I don't think should hold
> this patch up, but I want to mention on the list.
>
> If tmpfilename is set to something like "helloworld",
>
>             tmpFileName.AppendDir( wxT( "packages3d" ) );
>
> results in "packages3d/helloworld", which is not what I expected.  If you
> add slashes, however, and set  tmpFileName to "/helloworld/",
>
>             tmpFileName.AppendDir( wxT( "packages3d" ) );
>
> results in "/helloworld/packages3d".
>
> *sigh*
>
> Adam Wolf
>
>
> On Mon, Dec 7, 2015 at 9:36 AM, Adam Wolf <adamwolf@xxxxxxxxxxxxxxxxxxxx>
> wrote:
>
>> The test build is going now, will be done within 30 minutes.
>>
>> Adam Wolf
>>
>> On Mon, Dec 7, 2015 at 9:31 AM, Wayne Stambaugh <stambaughw@xxxxxxxxx>
>> wrote:
>>
>>> Adam,
>>>
>>> I forgot to ask, do you want me to go ahead with this patch?
>>>
>>> Thanks,
>>>
>>> Wayne
>>>
>>> On 12/6/2015 7:13 PM, Adam Wolf wrote:
>>> > When are you planning on doing the 4.0.1 release? Todayish or in about
>>> 7
>>> > days?
>>> >
>>> > Adam Wolf
>>> >
>>> >
>>> > On Sun, Dec 6, 2015, 5:41 PM Wayne Stambaugh <stambaughw@xxxxxxxxx
>>> > <mailto:stambaughw@xxxxxxxxx>> wrote:
>>> >
>>> >     On 12/6/2015 3:52 PM, Adam Wolf wrote:
>>> >     > If it would help the installer, would it help if we ifdef OSX
>>> out,
>>> >     and I
>>> >     > test on OS X next week and we remove the ifdef?
>>> >     >
>>> >     > I am also relatively comfortable applying this on OS X without
>>> testing
>>> >     > it.  I have been neck deep in that code over the last few weeks
>>> >     because
>>> >     > of the 3D modules work I was doing for OS X in prep for 4.0.0
>>> and it
>>> >     > looks OK to me.
>>> >
>>> >     If your comfortable with it, I will commit it to the product
>>> branch and
>>> >     merge it into the 4.0 branch for the 4.0.1 release.  Let me know if
>>> >     that's what you want me to do.  This is one of the rare exceptions
>>> I
>>> >     will make as far as back porting non-critical bugs.
>>> >
>>> >     >
>>> >     > Either way, I know I can test this early this week.
>>> >     >
>>> >     > Adam Wolf
>>> >     >
>>> >     > On Sun, Dec 6, 2015 at 2:48 PM, Nick Østergaard <
>>> oe.nick@xxxxxxxxx
>>> >     <mailto:oe.nick@xxxxxxxxx>
>>> >     > <mailto:oe.nick@xxxxxxxxx <mailto:oe.nick@xxxxxxxxx>>> wrote:
>>> >     >
>>> >     >     I am very tempted to just apply this to the 4.0.0 windows
>>> >     installer,
>>> >     >     just such that the libs will actually work when people
>>> install
>>> >     them.
>>> >     >
>>> >     >     Should I refrain from this?
>>> >     >
>>> >     >     I have tested the patch on windows and linux. It works as
>>> >     expected.
>>> >     >
>>> >     >     2015-12-04 15:21 GMT+01:00 Wayne Stambaugh
>>> >     <stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx>
>>> >     >     <mailto:stambaughw@xxxxxxxxx <mailto:stambaughw@xxxxxxxxx
>>> >>>:
>>> >     >     > Obviously this patch is only going to be useful for the
>>> >     first time
>>> >     >     kicad
>>> >     >     > is run.  Existing installs will change.  I'm fine with
>>> >     applying it
>>> >     >     once
>>> >     >     > it has been tested on OSX and Linux.  I'm at my bandwidth
>>> >     limit so I'm
>>> >     >     > going to need some help with the testing.
>>> >     >     >
>>> >     >     > On 12/4/2015 9:08 AM, Mark Roszko wrote:
>>> >     >     >> 1. Users can install anywhere
>>> >     >     >> 2. x86 vs x64
>>> >     >     >>
>>> >     >     >> 32-bit on XP => Program Files
>>> >     >     >> 32-bit on 64-bit => Program Files (x86)
>>> >     >     >> 64 on 64-bit => Program Files
>>> >     >     >> 64 on the rare 64-bit XP => Program Files (x64)
>>> >     >     >>
>>> >     >     >> _______________________________________________
>>> >     >     >> Mailing list: https://launchpad.net/~kicad-developers
>>> >     >     >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>> >     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>> >     >     >> Unsubscribe : https://launchpad.net/~kicad-developers
>>> >     >     >> More help   : https://help.launchpad.net/ListHelp
>>> >     >     >>
>>> >     >     >
>>> >     >     >
>>> >     >     > _______________________________________________
>>> >     >     > Mailing list: https://launchpad.net/~kicad-developers
>>> >     >     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>> >     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>> >     >     > Unsubscribe : https://launchpad.net/~kicad-developers
>>> >     >     > More help   : https://help.launchpad.net/ListHelp
>>> >     >
>>> >     >     _______________________________________________
>>> >     >     Mailing list: https://launchpad.net/~kicad-developers
>>> >     >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>> >     >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>>
>>> >     >     Unsubscribe : https://launchpad.net/~kicad-developers
>>> >     >     More help   : https://help.launchpad.net/ListHelp
>>> >     >
>>> >     >
>>> >
>>>
>>
>>
>

Follow ups

References