← Back to team overview

kicad-developers team mailing list archive

Re: [patch] default kicad_common to environment variables

 

That's what the patch does now.. Someone using msys2  for anything other
than compiling is a bit strange though.
On Dec 7, 2015 4:59 PM, "Wayne Stambaugh" <stambaughw@xxxxxxxxx> wrote:

> On 12/7/2015 3:48 PM, Mark Roszko wrote:
> > Updated patch to use AssignDir instead of me stupidly assigning to
> wxFilename.
> >
> > I added an empty var check(so it uses default instead) but it's
> > pointless. Windows disallows
> > empty env vars. On other systems if its empty you have configuration
> > issues and you should be fixing them, not kicad.
>
> Using the msys2 environment you can assign an empty env variable so we
> should definitely test the return string to see if it's empty and fall
> back to the default if it is empty.
>
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Follow ups

References