← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Fix broken language in duplicate zone error message

 

Le 08/12/2015 00:19, Chris Pavlina a écrit :
> The following error messages in pcbnew are poorly written:
> 
> - The duplicated zone is on the same layer as the initial zone, which 
>   has no sense. Please, choose another layer for the new zone.
> 
>   + for obvious reasons, broken English
> 
> - The outline of the duplicated zone fails DRC check!
> 
>   + "DRC check" is redundant
>   + This is erroneously displayed as an error - it's a warning, not an 
>     error. The operation actually proceeds in spite of the "error".
>   + "The outline of the duplicated zone" is slightly confusing and 
>     ambiguous
>   + The exclamation point makes it read weirdly excited
> 
> This patch rewrites them:
> 
> - "The duplicated zone cannot be on the same layer as the original 
>   zone."
> 
> - "Warning: The new zone fails DRC" (also changed this from DisplayError 
>   to DisplayInfoMessage)
> 
> Apologies for the patch noise, but someone pointed this out to me on IRC
> and I couldn't help myself :)
> 
> --
> Chris

Committed. Thanks.


-- 
Jean-Pierre CHARRAS


References