← Back to team overview

kicad-developers team mailing list archive

Re: [rfc patch] replace avhttp with libcurl

 

That is a great idea!

On Tue, Dec 8, 2015, 3:35 PM Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:

> You can always set the KICAD_REPO_NAME to something useful like
> github-curl-patch so it will show up in the version info.
>
> On 12/8/2015 4:31 PM, Adam Wolf wrote:
> > Hmm. Is this something we want to do?  If someone says they have a
> > Windows nightly bzr rev blah blah blah, do we want to have to look up if
> > it has special patches?
> >
> > Can you make a special build for this?
> >
> > Adam Wolf
> >
> >
> > On Tue, Dec 8, 2015, 3:25 PM Nick Østergaard <oe.nick@xxxxxxxxx
> > <mailto:oe.nick@xxxxxxxxx>> wrote:
> >
> >     The next windows nightly (non debug) and after
> >     kicad-product-r6353.2667109-x86_64.exe  will be patched.
> >
> >     2015-12-08 21:49 GMT+01:00 Wayne Stambaugh <stambaughw@xxxxxxxxx
> >     <mailto:stambaughw@xxxxxxxxx>>:
> >     > I had the same problem as JP with the CA certs using a
> msys1/mingw32
> >     > build.  I tried using the CURL_CA_BUNDLE environment variable but
> that
> >     > didn't seem to help.  I cannot tell where libcurl is looking for
> the
> >     > certs and I even tried use curl --capath to point to the path to
> known
> >     > good certs and that didn't work either.  I did notice that the
> msys2
> >     > package for curl is heavily patched so it may be that the unpatched
> >     > version that I built and installed does not work.  This could be an
> >     > issue as there may be devs out there still using the old msys1 as
> >     their
> >     > development platform on windows.  Unlike JP, I did not have any
> issues
> >     > with my msys2/mingw32 build.  That worked fine.  I am concerned
> about
> >     > how well this will work in windows packages if libcurl is so path
> >     > sensitive.  Before I consider committing it, I need one of our
> windows
> >     > packagers to create a windows installer with it to make sure the
> certs
> >     > can be found no matter where it is installed on the system.  Please
> >     > consider adding a build configuration option initially rather than
> >     > completely kicking avhttp to the curb.  I would prefer to have a
> known
> >     > fallback in case something goes wrong.
> >     >
> >     > On 12/4/2015 12:40 AM, Mark Roszko wrote:
> >     >> Attached updated patch thats been rebased on the latest commits.
> >     >>
> >     >> Removed excess whitespace, added comments to KICAD_CURL
> >     >> Fixed the WIN32 warnings.
> >     >> Replaced a fprintf with wxLogError. Also added curl library info
> >     print
> >     >> on start via wxLogDebug.
> >     >>
> >     >>
> >     >>
> >     >> _______________________________________________
> >     >> Mailing list: https://launchpad.net/~kicad-developers
> >     >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     >> Unsubscribe : https://launchpad.net/~kicad-developers
> >     >> More help   : https://help.launchpad.net/ListHelp
> >     >>
> >     >
> >     > _______________________________________________
> >     > Mailing list: https://launchpad.net/~kicad-developers
> >     > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     > Unsubscribe : https://launchpad.net/~kicad-developers
> >     > More help   : https://help.launchpad.net/ListHelp
> >
> >     _______________________________________________
> >     Mailing list: https://launchpad.net/~kicad-developers
> >     Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >     <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
> >     Unsubscribe : https://launchpad.net/~kicad-developers
> >     More help   : https://help.launchpad.net/ListHelp
> >
>

References