kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Cirilo,

I was looking at the original commit and there is a bunch of trailing
white space in FindGLM.cmake.  I didn't check the cpp source changes for
trailing white space.  I'll clean it up this time.  In the future,
please clean up your trailing white space.

Thanks,

Wayne

On 12/9/2015 3:42 PM, Cirilo Bernardo wrote:
> Here's an even better patch which incorporates Brano's check on the
> return value.
> I wasn't checking for "-NOTFOUND". Sorry about the earlier half-assed patch.
> 
> On Thu, Dec 10, 2015 at 7:28 AM, Cirilo Bernardo
> <cirilo.bernardo@xxxxxxxxx <mailto:cirilo.bernardo@xxxxxxxxx>> wrote:
> 
>     My mistake - it was only concidence that the FindGLM script worked
>     since the
>     default search paths happened to have a glm/ directory.
> 
>     The attached patch should fix the problem.
> 
>     - Cirilo
> 
> 
>     On Thu, Dec 10, 2015 at 12:08 AM, Brano Panak <bpanak@xxxxxxxxx
>     <mailto:bpanak@xxxxxxxxx>> wrote:
> 
>         Hi,
>         on OSX in CMakeLists.txt
>         find_package( GLM 0.9.5.4 REQUIRED ) in my setup (osx + brew)
>         returns incorrect path resulting in compiling error glm/glm.hpp
>         not found. Include path found is: /usr/local/include/glm.
>         Correct should be: /usr/local/include because of includes from
>         sources are <glm/glm.hpp>
>         workaround could be changes in source to include <glm.hpp> or
>         change includes from cmake
> 
>         my workaround:
>         # Find GLM library
>         find_path(GLM_INCLUDE_DIR "glm/glm.hpp")
>         if(GLM_INCLUDE_DIR STREQUAL "GLM_INCLUDE_DIR-NOTFOUND")
>             message(STATUS "glm not found")
>         else()
>             message(STATUS "glm include dir: ${GLM_INCLUDE_DIR}")
>             include_directories("${GLM_INCLUDE_DIR}")
>         endif()
> 
>         however this will not check glm version, could you please
>         evaluate this workaround?
>         regards
>         Brano
> 
>         _______________________________________________
>         Mailing list: https://launchpad.net/~kicad-developers
>         Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>         <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx>
>         Unsubscribe : https://launchpad.net/~kicad-developers
>         More help   : https://help.launchpad.net/ListHelp
> 
> 
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>