kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #21797
Re: Patch: fix string formatting in ThrowIOError
-
To:
kicad-developers@xxxxxxxxxxxxxxxxxxx
-
From:
jp charras <jp.charras@xxxxxxxxxx>
-
Date:
Thu, 10 Dec 2015 09:14:13 +0100
-
In-reply-to:
<CAEQqtJxeZM3c4bXwGt2QS-1DT=VDJhixt-FTedhV=o9dO+AW0w@mail.gmail.com>
-
User-agent:
Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.4.0
Le 10/12/2015 05:59, Henner Zeller a écrit :
> Hi,
> Since the current implementation of formatting IO errors is not
> working platform independently (see mail thread 'Bug: ThrowIOError
> with GetChars() formatting parameter'), replaced these calls
> with the working wxString::Format().
>
> Commit message:
> o Replace questionable wxString::PrintfV() call (which doesn't work
> reliably on different platforms) with wxString::Format()
> o Extra win: due to use now of the THROW_IO_ERROR() macro, error messages
> contain line numbers.
>
> Patch:
> https://github.com/KiCad/kicad-source-mirror/compare/master...hzeller:avoid-wxstring-printfv.diff
>
> Cheers,
> Henner.
>
Committed. Thanks.
--
Jean-Pierre CHARRAS
References