← Back to team overview

kicad-developers team mailing list archive

Re: PATCH: fix some include bugs

 

No worries, KiCad has not exploded because of that;)

Cheers,
Orson

On 12/10/2015 10:29 AM, Cirilo Bernardo wrote:
> You're right - how did I make such a stupid mistake.  I need a holiday; I
> think  my mistake rate is too high lately. :)
> 
> - Cirilo
> 
> 
> On Thu, Dec 10, 2015 at 8:05 PM, Maciej Sumiński <maciej.suminski@xxxxxxx>
> wrote:
> 
>> Hi Cirilo,
>>
>> Should not it be 'GLM_INCLUDE_DIR' there?
>>
>> Regards,
>> Orson
>>
>> On 12/10/2015 02:09 AM, Cirilo Bernardo wrote:
>>> Some more header problems have been revealed by people building
>>> kicad since we switched to using the system's installed libglm.
>>> In many instances '#include <glm/glm.hpp>' only worked by
>>> coincidence - that is because the compiler has /usr/include in the
>>> search path and glm happened to be installed there. Local installs,
>>> whether system-wide or per-user, don't work. This patch adds
>>> the GLM include dir to the cvpcb and pcbnew CMakeLists.txt files
>>> to ensure that the glm directory can be found even when not installed in
>>> /usr/include.
>>>
>>> - Cirilo
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>>
>>
> 


Attachment: signature.asc
Description: OpenPGP digital signature


References