kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #21811
Re: OpenMP patch
-
To:
Wayne Stambaugh <stambaughw@xxxxxxxxx>, Nick Østergaard <oe.nick@xxxxxxxxx>
-
From:
Maciej Sumiński <maciej.suminski@xxxxxxx>
-
Date:
Thu, 10 Dec 2015 14:45:33 +0100
-
Authentication-results:
spf=pass (sender IP is 188.184.36.50) smtp.mailfrom=cern.ch; lists.launchpad.net; dkim=none (message not signed) header.d=none;lists.launchpad.net; dmarc=bestguesspass action=none header.from=cern.ch;
-
Cc:
KiCad Developers <kicad-developers@xxxxxxxxxxxxxxxxxxx>
-
In-reply-to:
<56697E8C.6060604@gmail.com>
-
Spamdiagnosticmetadata:
NSPM
-
Spamdiagnosticoutput:
1:23
-
User-agent:
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0
OpenMP is optional, it boosts the ratsnest calculation in GAL canvases.
It was in the section specific to both gcc and clang, what are other
compilers that we support?
Anyway, if it works for other compilers, I do not see a reason that
prevents enabling it.
Regards,
Orson
On 12/10/2015 02:30 PM, Wayne Stambaugh wrote:
> He didn't add it, he just moved it out of the GCC specific
> configuration. I'm not sure why openmp would only be required when
> using gcc and not other compilers (which technically are not supported).
> Do we even need openmp? Where is used in KiCad? If we do need it, is
> it only required when building kicad with gcc?
>
> On 12/10/2015 8:26 AM, Nick Østergaard wrote:
>> It was added in the patch by the other Simon.
>>
>> https://github.com/KiCad/kicad-source-mirror/commit/e87258510567cb95800178dec30b058c885c326c#diff-af3b638bc2a3e6c650974192a53c7291
>>
>> 2015-12-10 14:22 GMT+01:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
>>> I'm not sure why openmp would be a dependency that is compiler
>>> dependent. I didn't add the openmp dependency so I cannot comment on
>>> why this would be specific to gcc. Anyone else know why openmp was gcc
>>> specific?
>>>
>>> On 12/9/2015 7:15 PM, Simon Wells wrote:
>>>> In BZR-6363 a patch was made so that OpenMP worked on non-gcc compilers
>>>>
>>>>
>>>> check_find_package_result( OPENMP_FOUND "OpenMP" )
>>>>
>>>> Was also added, This appears to make OpenMP a dependency for building kicad?
>>>>
>>>> Is this meant to be the case or was this line added in error
>>>>
>>>> thanks
>>>>
>>>> Simon
>>>>
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help : https://help.launchpad.net/ListHelp
>>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help : https://help.launchpad.net/ListHelp
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
>
Attachment:
signature.asc
Description: OpenPGP digital signature
Follow ups
References