kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

I just committed the fix for this in r6367.  Please verify that it
resolves your build issues.

On 12/10/2015 12:18 PM, Nick Østergaard wrote:
> Hi Wayne
> 
> I hear that there is still an issue for OSX+homebrew users. We are
> missing the patch from Cirilio,
> https://lists.launchpad.net/kicad-developers/msg21790.html
> 
> Except he made a typo. Is should be GLM_INCLUDE_DIR insted of GLEW_INCLUDE_DIR.
> 
> 2015-12-10 17:59 GMT+01:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
>> On 12/10/2015 8:45 AM, Maciej Sumiński wrote:
>>> OpenMP is optional, it boosts the ratsnest calculation in GAL canvases.
>>> It was in the section specific to both gcc and clang, what are other
>>> compilers that we support?
>>
>> Technically we don't but hiding FindOpenMP in the gcc and clang compiler
>> config probably isn't the best choice.  OpenMP is likely to be supported
>> on other compilers.
>>
>> I removed the offending line that inadvertently made OpenMP a
>> requirement so everything should be fine.
>>
>>>
>>> Anyway, if it works for other compilers, I do not see a reason that
>>> prevents enabling it.
>>>
>>> Regards,
>>> Orson
>>>
>>> On 12/10/2015 02:30 PM, Wayne Stambaugh wrote:
>>>> He didn't add it, he just moved it out of the GCC specific
>>>> configuration.  I'm not sure why openmp would only be required when
>>>> using gcc and not other compilers (which technically are not supported).
>>>>  Do we even need openmp?  Where is used in KiCad?  If we do need it, is
>>>> it only required when building kicad with gcc?
>>>>
>>>> On 12/10/2015 8:26 AM, Nick Østergaard wrote:
>>>>> It was added in the patch by the other Simon.
>>>>>
>>>>> https://github.com/KiCad/kicad-source-mirror/commit/e87258510567cb95800178dec30b058c885c326c#diff-af3b638bc2a3e6c650974192a53c7291
>>>>>
>>>>> 2015-12-10 14:22 GMT+01:00 Wayne Stambaugh <stambaughw@xxxxxxxxx>:
>>>>>> I'm not sure why openmp would be a dependency that is compiler
>>>>>> dependent.  I didn't add the openmp dependency so I cannot comment on
>>>>>> why this would be specific to gcc.  Anyone else know why openmp was gcc
>>>>>> specific?
>>>>>>
>>>>>> On 12/9/2015 7:15 PM, Simon Wells wrote:
>>>>>>> In BZR-6363 a patch was made so that OpenMP worked on non-gcc compilers
>>>>>>>
>>>>>>>
>>>>>>> check_find_package_result( OPENMP_FOUND "OpenMP" )
>>>>>>>
>>>>>>> Was also added, This appears to make OpenMP a dependency for building kicad?
>>>>>>>
>>>>>>> Is this meant to be the case or was this line added in error
>>>>>>>
>>>>>>> thanks
>>>>>>>
>>>>>>> Simon
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>>>
>>>
>>>