← Back to team overview

kicad-developers team mailing list archive

Re: Removal of download_boost.cmake.

 

Ok, looking further, I think it is just an oversight, GLM_INCLUDE_DIR is
missing in 3d-viewer/CMakeLists.txt. Adding it as per the attached patch
fixes the error for me. The problem will only be seen when GLM is in a
different location from other libraries already included in CMakeLists.txt.

Wayne, will you pick up the attached one-liner patch directly?

Wayne Stambaugh <stambaughw@xxxxxxxxx> writes:

> What is the result of `grep GLM < CMakeCache.txt` when run from your
> build folder?  You should see something like:

Yes, it's very similar:

$ grep GLM < CMakeCache.txt 
//GLM library header path.
GLM_INCLUDE_DIR:PATH=/home/knielsen/kicad/include
//Details about finding GLM
FIND_PACKAGE_MESSAGE_DETAILS_GLM:INTERNAL=[/home/knielsen/kicad/include][0.9.6.3][v0.9.6.3(0.9.5.4)]
//ADVANCED property for variable: GLM_INCLUDE_DIR
GLM_INCLUDE_DIR-ADVANCED:INTERNAL=1
GLM_VERSION_MAJOR:INTERNAL=0
GLM_VERSION_MINOR:INTERNAL=9
GLM_VERSION_PATCH:INTERNAL=6
GLM_VERSION_TWEAK:INTERNAL=3

Clearly, cmake is finding my installed GLM library from the
CMAKE_INSTALL_PREFIX (as that is the only place ~/kicad/ is mentioned). I
get the same error if I explicitly put -DGLM_ROOT_DIR=$HOME/kicad/include on
the cmake line. It's probably just the missing GLM_INCLUDE_DIR in
3d-viewer/CMakeLists.txt

 - Kristian.

diff --git a/3d-viewer/CMakeLists.txt b/3d-viewer/CMakeLists.txt
index b48e505..47014f6 100644
--- a/3d-viewer/CMakeLists.txt
+++ b/3d-viewer/CMakeLists.txt
@@ -6,6 +6,7 @@ include_directories(
     ../pcbnew
     ../polygon
     ${GLEW_INCLUDE_DIR}
+    ${GLM_INCLUDE_DIR}
     ${INC_AFTER}
     )
 

Follow ups

References