kicad-developers team mailing list archive

[Maciej Sumiński <maciej.suminski@xxxxxxx>]

Hi Windsor,

Thank you for the patch, I like the results. Personally, I would love to
have it merged, but we need to check if it does not break anything on
other platforms first.

Regards,
Orson

On 12/14/2015 04:42 AM, Windsor Schmidt wrote:
> Hi everyone,
> 
> This is my first post to the list, so please go easy on me. :D I have made a couple of changes to improve the appearance of the GUI for users with dark themes in Linux. A patch is attached.
> 
> * Removed toolbar gradient by adding wxAUI_TB_PLAIN_BACKGROUND to
>   wxAuiToolBar style (gradient is the default).
> 
> * Removed the white border from the main project tree view
>   by replacing style constant wxSW_3D with wxSW_3DSASH.
> 
> * Removed the white border from wxAui panes in KiCad manager,
>   pcbnew, and eeschema by calling PaneBorder( false ) on AUI panes.
> 
> Here are some screenshots from my Arch Linux desktop running bspwm (GTK2):
> 
> Dark theme from trunk: http://i.imgur.com/o1ueuVm.png
> Dark theme after fixups: http://i.imgur.com/TMdu8TF.png
> Light theme from trunk: http://i.imgur.com/MohCz76.png
> Light theme after fixups: http://i.imgur.com/Oj6Bi0F.png
> 
> NOTE: That third fixup involves a loop that runs before updating the wxAUI manager. I duplicate this code in 3 places where the white border was most prominent (toolbars in the manager, eeschema, and pcbnew). I assume this routine could be centralized and called before any time the AUI manager is updated, however I don't know the KiCad codebase well enough to approach this.
> 
> Thanks. KiCad rocks!
> 
> -Windsor
> 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Attachment: signature.asc
Description: OpenPGP digital signature