← Back to team overview

kicad-developers team mailing list archive

Re: 6387 code organization

 

Le 20/12/2015 20:37, Chris Pavlina a écrit :
> Why is class DIALOG_GET_FOOTPRINT_BY_NAME in pcbnew/modules.cpp instead 
> of pcbnew/dialogs/dialog_get_footprint_by_name.cpp in rev 6387?
> 
> 

Because this is not very useful:
* dialog_get_footprint_by_name.cpp is not needed (nothing to put in this
file)
* It is only a code which could be in dialog_get_footprint_by_name.h
 (it is just an header), but this code has only 15 lines and is used
only in modules.cpp.
* Many other files contains this kind of small code.

Of course, if (when) it is used in other .cpp files, put it in
dialog_get_footprint_by_name.h could be good.

-- 
Jean-Pierre CHARRAS


Follow ups

References