← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Eeschema options step 2: template fields

 

On Dec 28, 2015 12:39 AM, "Jon Neal" <reportingsjr@xxxxxxxxx> wrote:
>
> Just tested this and A++ would apply patches again.

You're welcome to try, they should be idempotent :D

>
> This is so much cleaner than the old options dialog.
>
> Two small things:
> 1. Maybe title the tab "Default Symbol Fields"? It is a little wordy, but
other than that there isn't any info on /what/ it is default fields for.

"Default Component Fields"?

> 2. Auto-save time interval should probably be under Editing rather than
Display since it has more to do with editing stuff.

Huh, is it really under Display? That must have been a mistake. I agree,
Editing is much better. I'll move it there in patch #3 along with the
hotkeys.

>
> Jon
>
> On Sun, Dec 27, 2015 at 4:08 PM Chris Pavlina <pavlina.chris@xxxxxxxxx>
wrote:
>>
>> Urgh, today seems to be a great day for making mistakes. Take #3, I
>> found a bug. Sorry for the noise.
>>
>> On Sun, Dec 27, 2015 at 03:02:05PM -0500, Chris Pavlina wrote:
>> > Sorry, quick update - fix a couple (non-critical) signed/unsigned
>> > mismatches and remove an unused member. This is a new version of the
>> > patch in the previous mail, not an incremental patch.
>> >
>> > On Sun, Dec 27, 2015 at 01:25:24PM -0500, Chris Pavlina wrote:
>> > > Hi,
>> > >
>> > > This patch reimplements the Template/Default Fields page in the
Eeschema
>> > > options using wxGrid, making the table directly user-editable and
>> > > removing the somewhat dodgy code for the separate edit panel. This
fixes
>> > > <https://bugs.launchpad.net/kicad/+bug/1527309> as well as, IMO,
making
>> > > this dialog much more user-friendly. The field options have also been
>> > > upgraded to use the newer TransferData{To,From}Window methods.
>> > >
>> > > Step 3 will be to pull the hotkey manager into this dialog.
>> > >
>> > > --
>> > > Chris
>> > >
>> >
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp

References