kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Patch committed in product branch r6420.  Thanks.

Cheers,

Wayne

On 1/4/2016 3:03 PM, Bernhard Stegmaier wrote:
> From my point of view it is.
> What makes you unsure?
> 
> The comment about the #ifdefs was just about cosmetics.
> But, it keeps the changes (and possible performance impacts when not using USE_WX_GRAPHICS_CONTEXT) to OSX only.
> 
> However, a “clean” integration of the wxGraphicsContext stuff would mean bigger changes in all the old drawing code - and I think this isn’t worth it if the plan is going to GAL anyway.
> 
> 
> Regards,
> Bernhard
> 
>> On 04 Jan 2016, at 20:11, Wayne Stambaugh <stambaughw@xxxxxxxxx> wrote:
>>
>> Is this patch ready to be committed?
>>
>> On 1/4/2016 11:12 AM, Bernhard Stegmaier wrote:
>>> It adds some #ifdefs for not compiling the wxGraphicsContext stuff at all when USE_WX_GRAPHICS_CONTEXT isn’t in use.
>>> If you hate #ifdefs, this also could be dropped but then it will always check if wxGraphicsContext can be applied...
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>