kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxx>]

Chris,

I tested this patch and something doesn't look write (see attached
screenshot).  Shouldn't there be a fifth tab with the hot keys or is
there something else going on here?  This is a 32-bit build on windows
10.  I also saw the same thing on my windows 7 box at work.

Wayne

On 1/4/2016 8:35 PM, Chris Pavlina wrote:
> Third step, again to be merged on top of the previous ones. This one 
> pulls the Hotkeys dialog finally into the eeschema Preferences dialog. 
> To go with it, I also pulled the load/save hotkeys command into that 
> dialog, and for consistency, the load/save preferences command. These 
> are now an "Import/Export..." menu button inside the preferences dialog.
> 
> Also removed "List Hotkeys", as it's quite redundant - the hotkeys 
> editor lists them just fine.
> 
> This makes the Preferences menu quite small, and the new Preferences 
> dialog is still nice and neat IMO ^-^
> 
> My next step is to investigate the behavior of the Import/Export 
> Preferences command itself. It seems to be a bit buggy. After that I 
> will continue working on the minor GUI quirks I mentioned earlier.
> 
> 
> On Mon, Jan 04, 2016 at 04:28:20PM -0500, Chris Pavlina wrote:
>> Second step is to remove the pages from the hotkeys dialog and make it a 
>> single-page control, so we don't have nested tabs when it's brought into 
>> the already tabbed options dialog. This patch removes the pages, in 
>> favor of categories in the wxTreeListCtrl. It also makes the final few 
>> steps towards making the HOTKEY_LIST_CTRL fully embeddable.
>>
>> This patch applies on top of the previous one. I recommend keeping them 
>> as separate commits, just in case I've created any bugs (makes them 
>> easier to track down).
>>
>> There are a couple known GUI "quirks" - the columns are sized slightly 
>> wrong when there is a vectical scrollbar, and the column sizing changes 
>> a bit erratically when resizing the dialog. These are wx bugs. I'm going 
>> to address them after the logical bits are complete.
>>
>> On Mon, Jan 04, 2016 at 03:05:33PM -0500, Chris Pavlina wrote:
>>> Hi,
>>>
>>> First step in getting the hotkey configuration inside the main 
>>> preferences dialog is to refactor it a bit. This patch:
>>>
>>> - Replaces the wxListCtrl with a wxTreeListCtrl, allowing expandable 
>>>   categories in a future change.
>>>
>>> - Cleans up the code to make HOTKEY_LIST_CTRL function a bit better on 
>>>   its own.
>>>
>>> - Migrates this dialog as well to TransferData{To,From}Window, use 
>>>   matching TransferData{To,From}Control methods on HOTKEY_LIST_CTRL so 
>>>   it is easy to embed.
>>>
>>> Despite being replaced by a tree-type control, none of the behavior has 
>>> been changed yet. The appearance changes slightly due to wxTreeListCtrl 
>>> looking a bit different.
>>>
>>> --
>>> Chris
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp

Attachment: eeschema-options-issue.png
Description: PNG image