kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

I suppose I should report a few known bugs so far to save your time - 
this wasn't meant to be a completed patch, I just wanted help testing 
the primary logic.

1) Minor imbalance of button size between old buttons and ones I have 
added

2) Export Hotkeys saves the wrong data set (the set from global memory 
that would be overwritten by pressing OK, not the set from the GUI 
widget)

3) Column sizing is fixed, and may look bad with grotesquely unusual 
fonts or themes ;)

Plus one known bug of the hotkeys system itself that may be exposed by 
testing my code:

4) Some keys with international symbols cannot be used as hotkeys

I will have a final version fixing 1, 2, and 3 by tomorrow. Fixing 4 
would take some reworking of the hotkey system, so I think I'm going to 
leave that one as is for now (and perhaps file a report so we have it on 
record).

On Thu, Jan 07, 2016 at 10:52:52AM -0500, Wayne Stambaugh wrote:
> On 1/7/2016 9:59 AM, Chris Pavlina wrote:
> > Really? It applies just fine here with:
> > 
> >     patch -Np1 -i options.patch
> > 
> > In any case, here's a patch generated with the more usual mechanism:
> > 
> >     https://misc.c4757p.com/hotkeys.patch
> 
> This one does apply cleanly.  I'll let you know when I finish building
> an testing it.
> 
> Thanks,
> 
> Wayne
> 
> > 
> > Could also download the whole branch with:
> > 
> >     git clone -b options https://github.com/cpavlina/kicad
> > 
> > 
> > On Thu, Jan 07, 2016 at 09:53:58AM -0500, Wayne Stambaugh wrote:
> >> Chris,
> >>
> >> This patch does not apply cleanly against the tip of the product branch
> >> so I cannot test it.
> >>
> >> Cheers,
> >>
> >> Wayne
> >>
> >> On 1/7/2016 9:28 AM, Chris Pavlina wrote:
> >>> Hey, can I get a couple more people to test the latest version of my 
> >>> hotkeys patch? Particularly someone on OS X, as I've not run into the 
> >>> guy who usually guineapigs my stuff on OS X since finishing it... :) 
> >>> Though testing on ALL platforms is welcome.
> >>>
> >>> https://github.com/cpavlina/kicad/compare/options.patch
> >>>
> >>> Make sure setting hotkeys works for all keys, that everything looks 
> >>> halfway decent, no unexpected behavior, etc... Hotkeys can be reset by 
> >>> right-clicking them in the list and choosing "Reset".
> >>>
> >>> The 'helper' dialog I used seems to be a fairly popular approach for 
> >>> this - it's fairly difficult to catch *any* keypress on a control 
> >>> embedded in a complex window, there's too much trying to steal 
> >>> navigation keys and whatnot. In my testing (on wxGTK and wxMSW Win10) it 
> >>> seems quite robust.
> >>>
> >>> Thank you all in advance. :)
> >>>
> >>> --
> >>> Chris
> >>>
> >>> _______________________________________________
> >>> Mailing list: https://launchpad.net/~kicad-developers
> >>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >>> Unsubscribe : https://launchpad.net/~kicad-developers
> >>> More help   : https://help.launchpad.net/ListHelp
> >>>
> >>
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~kicad-developers
> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> More help   : https://help.launchpad.net/ListHelp