← Back to team overview

kicad-developers team mailing list archive

Re: [Bulk] Testing for hotkeys patch

 

Thanks for the testing.

On Thu, Jan 7, 2016 at 11:37 AM, <cullinan@xxxxxxxxxxxxxx> wrote:

> Hello, Chris!
>
> Attached is an idea/wish, how it could look like.
> I hope I am not too demanding/picky... ;-)
>
> On 2016-01-07 15:28, Chris Pavlina wrote:
> > Hey, can I get a couple more people to test the latest version of my
> > hotkeys patch? Particularly someone on OS X, as I've not run into the
> > guy who usually guineapigs my stuff on OS X since finishing it... :)
> > Though testing on ALL platforms is welcome.
> >
> > https://github.com/cpavlina/kicad/compare/options.patch
> >
> > Make sure setting hotkeys works for all keys, that everything looks
> > halfway decent, no unexpected behavior, etc... Hotkeys can be reset by
> > right-clicking them in the list and choosing "Reset".
>
> Double-clicking and more popping windows to show text which could
> be already there... hmmm... not my favorite. :-/
> I prefer to use spreadsheet style editing, so F2 should also edit a field.
> Put as much information in place as long as it doesn't overload the user.
> Reduce clicks as much as you can.
>

I know, but wx doesn't play nicely with other methods. Trust me, I've
tried. This seems to be a popular method for gtk applications for a reason.

It still works with just the keyboard, you can also press Enter to activate
the rows in the table.


>
> "Reset" Button might be named as "Reset (all?) to defaults" with
> a confirmation is popping up: "Are you sure, you want to reset
> all Hotkeys in current (whole tree(==all)/just current branch?) to
> it's defaults?"
>

Reset doesn't reset to defaults, it resets to the value it had before the
user changed it. It's like pressing Cancel for just that item.
Unfortunately, there *is* no way to reset to defaults, as there is no
global store of defaults anywhere in KiCad. I'd like to change that, but
it'll require some more refactoring, and other things are higher in
priority right now.


>
> > The 'helper' dialog I used seems to be a fairly popular approach for
> > this - it's fairly difficult to catch *any* keypress on a control
> > embedded in a complex window, there's too much trying to steal
> > navigation keys and whatnot. In my testing (on wxGTK and wxMSW Win10) it
> > seems quite robust.
>
> Can you simply avoid/hide that dialog as it doesn't ideally need to
> give additional bold-face information?
>

Nope. If it's not visible and focused it doesn't get events.


>
> > Thank you all in advance. :)
>
> Thanks for working on this great piece of software!
>
> Regards,
>
> CKO
>
> On 2016-01-07 15:28, Chris Pavlina wrote:
> > Hey, can I get a couple more people to test the latest version of my
> > hotkeys patch? Particularly someone on OS X, as I've not run into the
> > guy who usually guineapigs my stuff on OS X since finishing it... :)
> > Though testing on ALL platforms is welcome.
> >
> > https://github.com/cpavlina/kicad/compare/options.patch
> >
> > Make sure setting hotkeys works for all keys, that everything looks
> > halfway decent, no unexpected behavior, etc... Hotkeys can be reset by
> > right-clicking them in the list and choosing "Reset".
> >
> > The 'helper' dialog I used seems to be a fairly popular approach for
> > this - it's fairly difficult to catch *any* keypress on a control
> > embedded in a complex window, there's too much trying to steal
> > navigation keys and whatnot. In my testing (on wxGTK and wxMSW Win10) it
> > seems quite robust.
> >
> > Thank you all in advance. :)
> >
> > --
> > Chris
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
>

Follow ups

References