kicad-developers team mailing list archive
-
kicad-developers team
-
Mailing list archive
-
Message #22514
Re: Final? version of hotkeys patch
I like having the hotkeys under 'controls' - first, they _are_ controls,
and second, the controls page is really sparse otherwise, it looks a bit
silly without something in there. ;) Obviously it could be moved, I'm
not particularly attached to it one way or the other. I'd rather get
this merged as is first though, since it fixes outstanding bugs; we can
address the UI in a later commit.
As for the icons - I want icons too, but as it was, there were only two
unique icons for four menu items, and it made the icons a bit useless. I
want to add icons back in, but I want to take some time to think about
what the correct icons for each of those four items would be. I don't
like having the duplicated icons.
On Mon, Jan 11, 2016 at 05:32:48PM +0100, jp charras wrote:
> Le 11/01/2016 16:28, Chris Pavlina a écrit :
> > An updated version of the patch is attached - doesn't apply cleanly
> > anymore after 6442.
> >
>
> Thanks, Chris.
>
> Looks good for me, but I am thinking the hotkeys editor should be shown
> in a notebook new page specific to hotkeys, not the existing control
> page, in preferences dialog.
>
> Also, why there is no more icons in "preferences/import and export" submenu?
> All other menus/submenus have icons. Many guys like them.
>
> --
> Jean-Pierre CHARRAS
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help : https://help.launchpad.net/ListHelp
Follow ups
References