← Back to team overview

kicad-developers team mailing list archive

Re: PATCH: minor bug fix in IDF parser

 

Committed in 6452. Thank you.

On Tue, Jan 12, 2016 at 02:58:53PM +1100, Cirilo Bernardo wrote:
> The attached patch fixes a logic defect in the IDF parser in which a valid
> IDF component outline is rejected if the .END_ELECTRICAL (or
> .END_MECHANICAL) statement was followed by an end-of-file rather than an
> end-of-line.

> === modified file 'utils/idftools/idf_outlines.cpp'
> --- utils/idftools/idf_outlines.cpp	2015-05-28 07:20:43 +0000
> +++ utils/idftools/idf_outlines.cpp	2016-01-12 03:54:08 +0000
> @@ -3320,7 +3320,7 @@
>      // check RECORD 4
>      while( aLibFile.good() && !FetchIDFLine( aLibFile, iline, comment, pos ) );
>  
> -    if( ( !aLibFile.good() && aLibFile.eof() ) || iline.empty() )
> +    if( ( !aLibFile.good() && aLibFile.eof() ) && iline.empty() )
>      {
>          ostringstream ostr;
>  
> 

> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp



References