← Back to team overview

kicad-developers team mailing list archive

Re: Commit r6458.

 

Whas the FindwxWidgets.cmake cherrypicked from the upstream cmake?

I think the part that is the issue here is the part which was removed:
 # Flags are a string, not a list, fix it here
782        string(REPLACE ";" " "
783          wxWidgets_CXX_FLAGS "${wxWidgets_CXX_FLAGS}")

2016-01-13 3:59 GMT+01:00 Chris Pavlina <pavlina.chris@xxxxxxxxx>:
> That is a bizarre error from that! I didn't see anything that actually
> affected the configuration when I went over the patch (most of it seemed
> to be formatting and reporting), but I must have missed something.
>
> In Simon's defense, it was sent out to the list, if you didn't see it. I
> figured it was safe because I didn't see anything with real side
> effects, but obviously there was something hiding in all that silly
> formatting change. Sorry!
>
> On Tue, Jan 12, 2016 at 09:58:07PM -0500, Wayne Stambaugh wrote:
>> Simon and Chris,
>>
>> Commit r6458, completely broke building kicad on msys2/mingw so I
>> reverted it.  This should have been sent out as a patch for testing
>> before it was commit.  In the future please test configuration changes
>> thoroughly.  Here is the build failure:
>>
>> cd /E/build/mingw32/kicad/product-release-stock-boost/bitmaps_png &&
>> /E/msys64/mingw32/bin/g++.exe   -DHAVE_STDINT_H -DKICAD_KEEPCASE
>> -DKICAD_SCRIPTING -DKICAD_SCRIPTING_MODULES -DKICAD_SCRIPTING_WXPYTHON
>> -DUSE_OPENMP -DWXUSINGDLL -DWX_COMPATIBILITY -D_FILE_OFFSET_BITS=64
>> -D_UNICODE -D__USE_MINGW_ANSI_STDIO=1 -D__WXMSW__
>> -I/E/msys64/home/Wayne/src/kicad/product/include
>> -I/E/msys64/home/Wayne/src/kicad/product/bitmaps_png/. -isystem
>> /E/msys64/mingw32/lib/wx/include/msw-unicode-3.0 -isystem
>> /E/msys64/mingw32/include/wx-3.0 -I/E/msys64/mingw32/include
>> -I/E/build/mingw32/kicad/product-release-stock-boost
>> -I/E/msys64/mingw32/include/python2.7
>> -I/E/msys64/home/Wayne/src/kicad/product/scripting  -Wall
>> -Wno-deprecated-declarations -Wno-unused-local-typedefs
>> -Wno-strict-aliasing -fopenmp -mthreads;-fpermissive -O3 -DNDEBUG
>> -DNDEBUG -fvisibility=hidden -fno-keep-inline-dllexport   -o
>> CMakeFiles/bitmaps.dir/cpp_16/pinorient_right.cpp.obj -c
>> /E/msys64/home/Wayne/src/kicad/product/bitmaps_png/cpp_16/pinorient_right.cpp
>> g++.exe: fatal error: no input files
>> compilation terminated.
>> /bin/sh: -fpermissive: command not found
>>
>> It looks like the latest cmake version of FindwxWidgets is not going to fly.
>>
>> Cheers,
>>
>> Wayne
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


References