← Back to team overview

kicad-developers team mailing list archive

Re: Fwd: [PATCH] github_plugin -> curl -> openssl thread safety

 

I concur. I probably shouldn't be inflammatory esp considering I just 
became part of the commit team, but suggestions like this really are 
just /stupid/ and detract from attempts to make KiCad actually usable. 
Someone really needs to just bite the bullet, tell him the whole nginx 
crap and half the design of the github plugin in general is awful, and 
do this properly. We cannot go telling our users, many of whom are more 
firmly experienced in engineering than networking, to go setting up a 
bloody local web server to make their EDA software work.

This whole thing has been handled rather poorly. When bugs were first 
found, Dick should have just notified Mark of what the problems actually 
were, and one of the committers could have reverted the patch until the 
bugs were fixed. Instead he kept going at it in private, only 
communicating with a lucky few, replacing half the code with what looks 
to me no better than the original. We're statically linking "the 
required portions of" openssl now? Really? What about the license issues 
that were mentioned before? And even ignoring that, I've never seen any 
other programs that do that, surely we could figure this out just like 
they did and not resort to horrors like static linkage.

What happens when a critical security bug is found in openssl, and kicad 
is still using the old version because due to static linkage it's not 
receiving system updates to that library?

Personally I think we need to slow down, take a step back - maybe revert 
the original patch to get things working properly in the devel branch 
again, then let someone like Mark who can do this properly without 
introducing a bunch of security and maintainability issues. When Dick 
finds a bug, he can file a bug report like the rest of us, communicate 
with the rest of us like the team player I was told we're supposed to 
be, and perhaps help fix problems without just taking over development 
and kludging together a fix.

On Wed, Jan 13, 2016 at 12:36:56PM -0500, Mark Roszko wrote:
> >I still would never use the plugin without nginx, and I think that should be made more clear to those who wine about speed.
> >There is an awful lot of whining, and none of these people even seem to know about nginx.  nginx + github plugin is even faster than the PCB_IO plugin.

Final mini-rant: ***Stop the silly micro-optimizations!!*** Who cares if 
it's marginally faster, if he did the UI properly so it didn't totally 
freeze up and gave some indication of its progress, nobody would mind 
waiting a few seconds.


> I give up, suggestions like these are ridiculous. Feel free to
> rollback to avhttp. I just literally give up. o7
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp


Follow ups

References