kicad-developers team mailing list archive

[Bernhard Stegmaier <stegmaier@xxxxxxxxxxxxx>]

Yes, very nice… :)

Given that probably after this change guys like me really want to change the grid color on OS X I really vote for this small patch - at least in an ifdef’d OSX-only version.
I have seen nothing bad with left click in a very short test, don’t know how it is on other platforms.

The only thing I noticed is that when you click the button and select a color, then the button gets bigger than before.
However, this is only a cosmetic issue (and again, for now better than not being able to change color on OS X at all).

Patch still had a typo, attached the version working for me (without ifdefs).


Regards,
Bernhard

Attachment: color.patch
Description: Binary data

> On 14.01.2016, at 20:38, Simon Wells <swel024@xxxxxxxxx> wrote:
> 
> sorry messed up one line of the patch
> 
> On Fri, Jan 15, 2016 at 8:30 AM, Simon Wells <swel024@xxxxxxxxx> wrote:
>> Please find an attached patch, I am still working on my layer_widget
>> full patch but this should be useful in the interim
>> 
>> esspeically for those that don't have a 3-button mouse as there is no other way
>> 
>> On Fri, Jan 15, 2016 at 8:26 AM, Nick Østergaard <oe.nick@xxxxxxxxx> wrote:
>>> Yeah, I also noticed this, except I did not think of scrolling, but
>>> just switched to legacy and back.
>>> 
>>> 2016-01-14 20:04 GMT+01:00 Chris Pavlina <pavlina.chris@xxxxxxxxx>:
>>>> Tom, there's a minor bug with the grid color - I'd fix it myself, but
>>>> I'm not familiar with the GAL stuff yet and don't want to go breaking
>>>> anything. When you change the grid color while GAL is active, the grid
>>>> doesn't refresh until you change the zoom level. I assume fixing that is
>>>> as simple as sticking a refresh call of some sort in the right place?
>>>> 
>>>> 
>>>> On Thu, Jan 14, 2016 at 08:00:32PM +0100, Tomasz Wlostowski wrote:
>>>>> On 14.01.2016 19:57, Bernhard Stegmaier wrote:
>>>>>> Hi,
>>>>>> 
>>>>>> I know, I am difficult… :)
>>>>>> 
>>>>>> In GAL canvas grid was almost invisible up to now.
>>>>>> 
>>>>>> With one of the last commit it obviously respects grid color which it
>>>>>> didn’t before… yes, it is very visible now:
>>>>>> 
>>>>> 
>>>>> Hi Bernhard,
>>>>> 
>>>>> I fixed this aside fixing another grid-related issue in the GAL canvas.
>>>>> You can use the darkest colors if the grid is too bright :)
>>>>> 
>>>>>> I have seen in the code that a “dot” grid (using small rectangles) seems
>>>>>> to be implemented… any special reasons why this is not used?
>>>>> None - just nobody thought about it, until now.
>>>>> 
>>>>>> Should this maybe get a configuration option?
>>>>> 
>>>>> Sure.
>>>>> 
>>>>> Regards,
>>>>> Tom
>>>>> 
>>>>> _______________________________________________
>>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>> 
>>>> _______________________________________________
>>>> Mailing list: https://launchpad.net/~kicad-developers
>>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>>> More help   : https://help.launchpad.net/ListHelp
>>> 
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
> <kicad-color_click-v2.patch>