kicad-developers team mailing list archive

[Chris Pavlina <pavlina.chris@xxxxxxxxx>]

Hmm. From my perspective, I didn't really think it was a policy 
violation as such, as that is definitely not MSVC-specific. It's just 
"portable", which is generally a good thing - if we were ever to change 
the current policy in the future, the more portable the code is, the 
easier that will be. And who knows, it's possible we could have to do 
that in the future, if current toolchains are abandoned or something.

Personally I have absolutely no problem with making things more portable 
when there is no added complexity and nothing compiler-specific - I'd 
probably have committed this if you hadn't replied before I could get 
around to testing it.

Fair enuogh about not wanting to directly support MSVC, of course, I 
don't want that either. :)


On Sat, Jan 16, 2016 at 02:34:18PM -0500, Wayne Stambaugh wrote:
> Please do not commit this patch.  The current policy is no MSVC specific
> code in KiCad and I'm not interested in changing that policy any time soon.
> 
> Thanks,
> 
> Wayne
> 
> On 1/15/2016 11:41 PM, Simon Richter wrote:
> > 
> > Windows-style dllimport/dllexport should be used whenever targetting
> > Windows directly, not just for MINGW.
> > 
> > ---
> >  include/import_export.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > 
> > 
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> > 
> 
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp